Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented the workspace issues table #3340

Merged
merged 21 commits into from May 9, 2024
Merged

feat: implemented the workspace issues table #3340

merged 21 commits into from May 9, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 8, 2024 •
edited

Description

Adds an issues table to the activity tab of a workspace.

Note: You won't be able to test this until the API endpoint for it has been merged (see https://github.com/open-sauced/api/pull/774).

Related Tickets & Documents

Close #3322

Mobile & Desktop Screenshots/Recordings

CleanShot 2024-05-09 at 11 34 19

Workspace.Activity.Video.mp4

On mobile the heart reactions count only appears if it's greater than 0

CleanShot 2024-05-09 at 11 47 04

Steps to QA

  1. Go to any workspace
  2. Click on the Activity tab
  3. Click on the Issues tab
  4. The issues table loads

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 9a7a1e2
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/663d29288e84270008f01703
😎 Deploy Preview https://deploy-preview-3340--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 9a7a1e2
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/663d2928dc3c380008110fdb
😎 Deploy Preview https://deploy-preview-3340--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline changed the title feat: implemted the workspace issues table feat: implemented the workspace issues table May 8, 2024
@nickytonline
Copy link
Member Author

We have reactions available as well in the data @bdougie @isabensusan. Do you think it's worth surfacing them with their counts for each issue?

@bdougie
Copy link
Member

bdougie commented May 8, 2024 •
edited

We have reactions available as well in the data @bdougie @isabensusan. Do you think it's worth surfacing them with their counts for each issue?

That would be great. One of the things the GitHub cli/cli does is sort by most hearts. Literally how they prioritize their roadmap.

Also maybe the hearts.dev squad would find that useful

Cc @babblebey @gr2m

@nickytonline
Copy link
Member Author

We have reactions available as well in the data @bdougie @isabensusan. Do you think it's worth surfacing them with their counts for each issue?

That would be great. One of the things the GitHub cli/cli does is sort by most hearts. Literally how they prioritize their roadmap.

Also maybe the hearts.dev squad would find that useful

Cc @babblebey @gr2m

You can sort by hearts now. Just wondering if it makes sense to surface or sort by any other reactions like plus one or minus one, eyeballs etc.

@nickytonline
Copy link
Member Author

The sub tabs have been updated @bdougie @isabensusan.

CleanShot 2024-05-09 at 11 33 33

@nickytonline nickytonline marked this pull request as ready for review May 9, 2024 15:37
@nickytonline
Copy link
Member Author

Just sorting out the E2E tests and it would be good to get #3352 merged first.

@nickytonline nickytonline requested a review from a team May 9, 2024 17:11
bdougie
bdougie approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @nickytonline

@nickytonline nickytonline mentioned this pull request May 9, 2024
Merged
4 tasks
@nickytonline nickytonline requested a review from a team May 9, 2024 18:34
brandonroberts
brandonroberts approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I had to reselect repos after switching between tabs but no big deal.

@nickytonline nickytonline merged commit ba1bc51 into beta May 9, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/issues-table branch May 9, 2024 21:08
open-sauced bot pushed a commit that referenced this pull request May 9, 2024
@nickytonline @open-sauced
chore(minor): release 2.26.0-beta.3 on beta channel [skip ci]
0d3d38d 
## [2.26.0-beta.3](v2.26.0-beta.2...v2.26.0-beta.3) (2024-05-09)

### 🍕 Features

* implemented the workspace issues table ([#3340](#3340)) ([ba1bc51](ba1bc51))
open-sauced bot pushed a commit that referenced this pull request May 9, 2024
@nickytonline @open-sauced
chore(minor): release 2.26.0 [skip ci]
ee8fdec 
## [2.26.0](v2.25.0...v2.26.0) (2024-05-09)

### 🍕 Features

* add repository filtering to contributor insight activity page ([#3355](#3355)) ([58f6dda](58f6dda))
* implemented the substabs list component ([#3352](#3352)) ([5a55026](5a55026))
* implemented the workspace issues table ([#3340](#3340)) ([ba1bc51](ba1bc51))
* now low activity ratio pills are slate ([#3347](#3347)) ([18bd781](18bd781))

### 🐛 Bug Fixes

* now markdown has common styles ([6200d76](6200d76))
* now markdown has common styles ([#3339](#3339)) ([1db8260](1db8260))
* style tweaks for MultiSelect component ([#3354](#3354)) ([6cf9f99](6cf9f99))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@bdougie bdougie bdougie approved these changes

@isabensusan isabensusan Awaiting requested review from isabensusan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Issues Table
3 participants
@nickytonline @bdougie @brandonroberts