Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: now low activity ratio pills are slate #3347

Merged
merged 1 commit into from
May 9, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 8, 2024

Description

Now low activity ratio pills are slate for the workspace engagement card and repository table rows.

Related Tickets & Documents

Closes #3345

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-05-08 at 17 59 31

CleanShot 2024-05-08 at 17 59 03

After

CleanShot 2024-05-08 at 17 59 53

CleanShot 2024-05-08 at 17 58 14

Steps to QA

  1. Go to a workspace overview page with low activity ratio.
  2. Notice the pill component for low activity ratio is slate now instead of read.
  3. You might need to page through the repository table, but the low activity ratio is slate there as well now too.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 8, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit f38fd6d
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/663bf505a0a08d0008d0f943
😎 Deploy Preview https://deploy-preview-3347--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit f38fd6d
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/663bf5052614680008610a4d
😎 Deploy Preview https://deploy-preview-3347--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from isabensusan and a team May 8, 2024 22:00
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧧 🧧 🧧

@nickytonline nickytonline requested a review from zeucapua May 8, 2024 22:46
@nickytonline nickytonline merged commit 18bd781 into beta May 9, 2024
25 checks passed
@nickytonline nickytonline deleted the nickytonline/low-activity-ratio-color-change branch May 9, 2024 00:38
open-sauced bot pushed a commit that referenced this pull request May 9, 2024
## [2.26.0-beta.1](v2.25.1-beta.1...v2.26.0-beta.1) (2024-05-09)

### 🍕 Features

* now low activity ratio pills are slate ([#3347](#3347)) ([18bd781](18bd781))
open-sauced bot pushed a commit that referenced this pull request May 9, 2024
## [2.26.0](v2.25.0...v2.26.0) (2024-05-09)

### 🍕 Features

* add repository filtering to contributor insight activity page ([#3355](#3355)) ([58f6dda](58f6dda))
* implemented the substabs list component ([#3352](#3352)) ([5a55026](5a55026))
* implemented the workspace issues table ([#3340](#3340)) ([ba1bc51](ba1bc51))
* now low activity ratio pills are slate ([#3347](#3347)) ([18bd781](18bd781))

### 🐛 Bug Fixes

* now markdown has common styles ([6200d76](6200d76))
* now markdown has common styles ([#3339](#3339)) ([1db8260](1db8260))
* style tweaks for MultiSelect component ([#3354](#3354)) ([6cf9f99](6cf9f99))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: change "low" activity badge to gray instead of red
3 participants