Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make Star Search feature visible on mobile for other pages #3371

Closed
brandonroberts opened this issue May 13, 2024 · 6 comments · Fixed by #3374
Closed

Feature: Make Star Search feature visible on mobile for other pages #3371

brandonroberts opened this issue May 13, 2024 · 6 comments · Fixed by #3374
Assignees
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. released on @beta released

Comments

@brandonroberts
Copy link
Contributor

brandonroberts commented May 13, 2024

Suggested solution

When on mobile, there's no easy way to get to StarSearch unless you know how to navigate around to a workspace.

image image

Suggestion: Use a similar pattern to the Upgrade Banner to show a banner for StarSearch with a link to go to it

image

Pages to show banner:

  • Explore
  • Highlights
  • Repo pages
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@brandonroberts brandonroberts added needs design Front-end tasks that are missing a design. Create a new issue for the design. and removed 👀 needs triage labels May 13, 2024
@bdougie
Copy link
Member

bdougie commented May 13, 2024

This is something I brought up on my call with Brandon when demoing the product videos I was planning. A banner would get my vote as a quick add. We could potentially add the star search logo next to the search icon as well.

@nickytonline
Copy link
Member

For design, we already have the logo, so the top nav will be quick to do. I can do that now. For wording in the banner, let me know and I can pop that in as well.

@jpmcb
Copy link
Member

jpmcb commented May 13, 2024

I was just about to open an issue on this: wanted to show this off in San Fran and kept having to go to the URL bar and typing in the endpoint manually

Screenshot 2024-05-13 at 3 51 25 PM

Copy link

open-sauced bot commented May 14, 2024

🎉 This issue has been resolved in version 2.27.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

open-sauced bot commented May 15, 2024

🎉 This issue has been resolved in version 2.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature needs design Front-end tasks that are missing a design. Create a new issue for the design. released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants