Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unnecessary props and logic from HeaderLogo component #3375

Closed
wants to merge 1 commit into from

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 13, 2024

Description

Removes unnecessary props and logic from HeaderLogo component that was discovered while working on #3371.

Note: #3374 needs to be merged first.

Related Tickets & Documents

Relates to #3371

Mobile & Desktop Screenshots/Recordings

N/A

Steps to QA

Same steps as #3371.

  1. Go to any page and resize it to a small size.
  2. Notice StarSearch remains in the menu.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 13, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit ae0a815
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6642a014b7b75a0008bcf1ab
😎 Deploy Preview https://deploy-preview-3375--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit ae0a815
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6642a014e3a55700073f25b3
😎 Deploy Preview https://deploy-preview-3375--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team May 13, 2024 23:18
@nickytonline nickytonline force-pushed the nickytonline/header-logo-cleanup branch from 57bcf80 to ae0a815 Compare May 13, 2024 23:19
@nickytonline nickytonline deleted the nickytonline/header-logo-cleanup branch June 28, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant