Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Validations when creating a page, make the page title required with at least one repo #852

Closed
Tracked by #760
bdougie opened this issue Feb 9, 2023 · 3 comments · Fixed by #857
Closed
Tracked by #760

feature: Validations when creating a page, make the page title required with at least one repo #852

bdougie opened this issue Feb 9, 2023 · 3 comments · Fixed by #857
Assignees
@takanome-dev
Labels
released on @alpha released
Milestone
Papercuts

Comments

@bdougie
Copy link
Member

bdougie commented Feb 9, 2023 •
edited

Screen Shot 2023-02-09 at 4 51 42 AM

Solution:

  • Make the page name a required field
  • Disable the create page button until a name is added

Screen Shot 2023-02-09 at 4 54 16 AM
@bdougie bdougie mentioned this issue Feb 9, 2023
Closed
5 tasks
@bdougie bdougie changed the title Validations when creating a page, make the page title required with at least one repo feature: Validations when creating a page, make the page title required with at least one repo Feb 9, 2023
@bdougie bdougie added this to the Papercuts milestone Feb 9, 2023
@takanome-dev takanome-dev self-assigned this Feb 9, 2023
@takanome-dev
Copy link
Contributor

@bdougie is it necessary to add a red asterisk at the top right hand of the label?

@takanome-dev takanome-dev mentioned this issue Feb 9, 2023
Merged
19 tasks
brandonroberts pushed a commit that referenced this issue Feb 15, 2023
@takanome-dev
feat: disable create insight page button if the page name is missing (#…
95da564 
…857)

Fixes #852
github-actions bot pushed a commit that referenced this issue Feb 15, 2023
@takanome-dev @open-sauced
chore(minor): release 1.30.0-beta.1 on beta channel [skip ci]
2eaddab 
## [1.30.0-beta.1](v1.29.0...v1.30.0-beta.1) (2023-02-15)

### 🍕 Features

* disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)
github-actions bot pushed a commit that referenced this issue Feb 17, 2023
@brandonroberts @open-sauced
chore(minor): release 1.30.0-alpha.2 on alpha channel [skip ci]
162b0b7 
## [1.30.0-alpha.2](v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17)

### 🍕 Features

* add  highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830)
* add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533)
* disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)

### 🐛 Bug Fixes

* enable displaying/editing of insight page repos from API ([f4cc62f](f4cc62f))
* formatting ([065ede0](065ede0))
* reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.30.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Feb 21, 2023
@brandonroberts @open-sauced
chore(minor): release 1.30.0 [skip ci]
26ab744 
## [1.30.0](v1.29.0...v1.30.0) (2023-02-21)

### 🍕 Features

* add  highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830)
* add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533)
* disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)

### 🐛 Bug Fixes

* disable create page button only if insight page name is empty ([#893](#893)) ([ed52399](ed52399)), closes [#892](#892)
* hide non-functional elements in highlights card ([#881](#881)) ([ba1bd5e](ba1bd5e))
* rename 404 image file ([4e5171f](4e5171f))
* replace `PRSocialCard` component with GitHub OpenGraph image ([#889](#889)) ([3bfc5a4](3bfc5a4)), closes [#883](#883)
* reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)
* user profile interest pill UI fix ([#890](#890)) ([4cbff36](4cbff36))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.30.0-beta.1 on beta channel [skip ci]
6a04d8d 
## [1.30.0-beta.1](open-sauced/app@v1.29.0...v1.30.0-beta.1) (2023-02-15)

### 🍕 Features

* disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.30.0-alpha.2 on alpha channel [skip ci]
76172a5 
## [1.30.0-alpha.2](open-sauced/app@v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17)

### 🍕 Features

* add  highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
* add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533)
* disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)

### 🐛 Bug Fixes

* enable displaying/editing of insight page repos from API ([f4cc62f](open-sauced/app@f4cc62f))
* formatting ([065ede0](open-sauced/app@065ede0))
* reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.30.0 [skip ci]
6785fb8 
## [1.30.0](open-sauced/app@v1.29.0...v1.30.0) (2023-02-21)

### 🍕 Features

* add  highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
* add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533)
* disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)

### 🐛 Bug Fixes

* disable create page button only if insight page name is empty ([#893](open-sauced/app#893)) ([ed52399](open-sauced/app@ed52399)), closes [#892](open-sauced/app#892)
* hide non-functional elements in highlights card ([#881](open-sauced/app#881)) ([ba1bd5e](open-sauced/app@ba1bd5e))
* rename 404 image file ([4e5171f](open-sauced/app@4e5171f))
* replace `PRSocialCard` component with GitHub OpenGraph image ([#889](open-sauced/app#889)) ([3bfc5a4](open-sauced/app@3bfc5a4)), closes [#883](open-sauced/app#883)
* reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)
* user profile interest pill UI fix ([#890](open-sauced/app#890)) ([4cbff36](open-sauced/app@4cbff36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takanome-dev takanome-dev

Labels
released on @alpha released
Projects
No open projects
OpenSauced Operational Roadmap
Status: Done
Milestone
Papercuts
Development

Successfully merging a pull request may close this issue.

feat: disable create page btn if the page name is missing takanome-dev/insights
2 participants
@bdougie @takanome-dev