New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add highlights to user profile page #859
Conversation
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Realized this will need this component when there is no highlights. |
I can include in this PR as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some important stuff to change before you spend too much work on it! π₯
components/molecules/ContributorHighlight/contributor-highlight-card.tsx
Outdated
Show resolved
Hide resolved
@@ -3,7 +3,8 @@ module.exports = { | |||
theme: { | |||
extend: { | |||
gridTemplateColumns: { | |||
autodesktop: "repeat(auto-fit, minmax(410px, 1fr))", automobile: "repeat(auto-fit, minmax(300px, 1fr))" | |||
autodesktop: "repeat(auto-fit, minmax(410px, 1fr))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this as we are not using grid across the application, we are using flex
components/organisms/ContributorProfileTab/contributor-profile-tab.tsx
Outdated
Show resolved
Hide resolved
β¦uced/insights into 830-profile-hight=lights
How soon can this be ready? |
I can get this today |
components/molecules/ContributorHighlight/contributor-highlight-card.tsx
Outdated
Show resolved
Hide resolved
components/molecules/ContributorHighlight/contributor-highlight-card.tsx
Outdated
Show resolved
Hide resolved
components/molecules/ContributorHighlight/contributor-highlight-card.tsx
Outdated
Show resolved
Hide resolved
β¦t-card.tsx Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
β¦t-card.tsx Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
β¦t-card.tsx Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
β¦uced/insights into 830-profile-hight=lights
π This PR is included in version 1.30.0-beta.4 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.30.0-alpha.2](v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### π Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### π Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](f4cc62f)) * formatting ([065ede0](065ede0)) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)
π This PR is included in version 1.30.0-alpha.2 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.30.0](v1.29.0...v1.30.0) (2023-02-21) ### π Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### π Bug Fixes * disable create page button only if insight page name is empty ([#893](#893)) ([ed52399](ed52399)), closes [#892](#892) * hide non-functional elements in highlights card ([#881](#881)) ([ba1bd5e](ba1bd5e)) * rename 404 image file ([4e5171f](4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](#889)) ([3bfc5a4](3bfc5a4)), closes [#883](#883) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858) * user profile interest pill UI fix ([#890](#890)) ([4cbff36](4cbff36))
π This PR is included in version 1.30.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.30.0-beta.4](open-sauced/app@v1.30.0-beta.3...v1.30.0-beta.4) (2023-02-17) ### π Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
## [1.30.0-alpha.2](open-sauced/app@v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### π Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### π Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](open-sauced/app@f4cc62f)) * formatting ([065ede0](open-sauced/app@065ede0)) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)
## [1.30.0](open-sauced/app@v1.29.0...v1.30.0) (2023-02-21) ### π Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### π Bug Fixes * disable create page button only if insight page name is empty ([#893](open-sauced/app#893)) ([ed52399](open-sauced/app@ed52399)), closes [#892](open-sauced/app#892) * hide non-functional elements in highlights card ([#881](open-sauced/app#881)) ([ba1bd5e](open-sauced/app@ba1bd5e)) * rename 404 image file ([4e5171f](open-sauced/app@4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](open-sauced/app#889)) ([3bfc5a4](open-sauced/app@3bfc5a4)), closes [#883](open-sauced/app#883) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858) * user profile interest pill UI fix ([#890](open-sauced/app#890)) ([4cbff36](open-sauced/app@4cbff36))
What type of PR is this? (check all applicable)
Description
This PR:
generateApiPrUrl
functions inutils
to generate valid endpoint to fetch users PR using GitHub APINotes
Related Tickets & Documents
Closes #830
Mobile & Desktop Screenshots/Recordings
Invalid PR link
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?