Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlights to user profile page #859

Merged
merged 38 commits into from Feb 17, 2023

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Feb 9, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR:

  • Implements user highlights display on profile page
  • implements create highlights on user profile page
  • creates a generateApiPrUrl functions in utils to generate valid endpoint to fetch users PR using GitHub API
  • Adds PR card preview on valid PR link added to the highlights body on creations
  • Adds loading skeleton for highlights loading state
  • Fix the responsiveness issue with the profile header
  • Adds implementation for sharing on Twitter and LinkedIn

Notes

Related Tickets & Documents

Closes #830

Mobile & Desktop Screenshots/Recordings

image

image

image

image

image

Invalid PR link

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Feb 9, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 6e1bdea
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63efc0766aae980008d481f8
😎 Deploy Preview https://deploy-preview-859--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 9, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 6e1bdea
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63efc0760d9e4800081b47fe
😎 Deploy Preview https://deploy-preview-859--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdougie
Copy link
Member

bdougie commented Feb 9, 2023

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Feb 9, 2023

Realized this will need this component when there is no highlights.

image

https://www.figma.com/file/OpVX6WT7dmWqnwRuEvADMF/OpenSauced-%E2%80%94-Insights-(insights.opensauced.pizza)?node-id=6579%3A8814&t=R24oIhwcD3cC7R9s-1

I can include in this PR as well

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some important stuff to change before you spend too much work on it! πŸ”₯

components/atoms/Tabs/tabs.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@@ -3,7 +3,8 @@ module.exports = {
theme: {
extend: {
gridTemplateColumns: {
autodesktop: "repeat(auto-fit, minmax(410px, 1fr))", automobile: "repeat(auto-fit, minmax(300px, 1fr))"
autodesktop: "repeat(auto-fit, minmax(410px, 1fr))",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this as we are not using grid across the application, we are using flex

lib/utils/github.ts Outdated Show resolved Hide resolved
@bdougie
Copy link
Member

bdougie commented Feb 13, 2023

Mobile screen is not there. image

lib/utils/cn.ts Outdated Show resolved Hide resolved
@OgDev-01
Copy link
Contributor Author

@getaheaddev could potential draw us an "uh oh" or 404 image.

I can do that!

How soon can this be ready?

@getaheaddev
Copy link

@getaheaddev could potential draw us an "uh oh" or 404 image.

I can do that!

How soon can this be ready?

I can get this today

@brandonroberts brandonroberts merged commit 4b01376 into beta Feb 17, 2023
@brandonroberts brandonroberts deleted the 830-profile-hight=lights branch February 17, 2023 19:10
github-actions bot pushed a commit that referenced this pull request Feb 17, 2023
## [1.30.0-beta.4](v1.30.0-beta.3...v1.30.0-beta.4) (2023-02-17)

### πŸ• Features

* add  highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.30.0-beta.4 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Feb 17, 2023
## [1.30.0-alpha.2](v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17)

### πŸ• Features

* add  highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830)
* add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533)
* disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)

### πŸ› Bug Fixes

* enable displaying/editing of insight page repos from API ([f4cc62f](f4cc62f))
* formatting ([065ede0](065ede0))
* reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.30.0-alpha.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
## [1.30.0](v1.29.0...v1.30.0) (2023-02-21)

### πŸ• Features

* add  highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830)
* add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533)
* disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)

### πŸ› Bug Fixes

* disable create page button only if insight page name is empty ([#893](#893)) ([ed52399](ed52399)), closes [#892](#892)
* hide non-functional elements in highlights card ([#881](#881)) ([ba1bd5e](ba1bd5e))
* rename 404 image file ([4e5171f](4e5171f))
* replace `PRSocialCard` component with GitHub OpenGraph image ([#889](#889)) ([3bfc5a4](3bfc5a4)), closes [#883](#883)
* reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)
* user profile interest pill UI fix ([#890](#890)) ([4cbff36](4cbff36))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.30.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.30.0-beta.4](open-sauced/app@v1.30.0-beta.3...v1.30.0-beta.4) (2023-02-17)

### πŸ• Features

* add  highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.30.0-alpha.2](open-sauced/app@v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17)

### πŸ• Features

* add  highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
* add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533)
* disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)

### πŸ› Bug Fixes

* enable displaying/editing of insight page repos from API ([f4cc62f](open-sauced/app@f4cc62f))
* formatting ([065ede0](open-sauced/app@065ede0))
* reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.30.0](open-sauced/app@v1.29.0...v1.30.0) (2023-02-21)

### πŸ• Features

* add  highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830)
* add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533)
* disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)

### πŸ› Bug Fixes

* disable create page button only if insight page name is empty ([#893](open-sauced/app#893)) ([ed52399](open-sauced/app@ed52399)), closes [#892](open-sauced/app#892)
* hide non-functional elements in highlights card ([#881](open-sauced/app#881)) ([ba1bd5e](open-sauced/app@ba1bd5e))
* rename 404 image file ([4e5171f](open-sauced/app@4e5171f))
* replace `PRSocialCard` component with GitHub OpenGraph image ([#889](open-sauced/app#889)) ([3bfc5a4](open-sauced/app@3bfc5a4)), closes [#883](open-sauced/app#883)
* reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)
* user profile interest pill UI fix ([#890](open-sauced/app#890)) ([4cbff36](open-sauced/app@4cbff36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add highlights to user profiles
5 participants