feat: add dropdown for topics in Explore #877

nightknighto · 2023-02-15T15:03:35Z

What type of PR is this? (check all applicable)

Description

Adds a new (atom) component for selector.
Adds a new (molecule) component for filter card with selection.
Changes the camelCaseNaming lib into a more general name-formatting function
Implements the new filter card with selection component to enable selecting topics from a pre-defined list in Explore.

Follow-up tasks

A new issue should be made to re-use the new selector component in the existing superlative-selector

Related Tickets & Documents

closes #533

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-02-15T15:04:14Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`ce8b546`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63ee6a3afbf4060008c427fb
😎 Deploy Preview	https://deploy-preview-877--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-02-15T15:04:18Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`ce8b546`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63ee6a3af57cf80008e9b974
😎 Deploy Preview	https://deploy-preview-877--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie

This section is meant to share totals PRs represented in the topic. If that is not possible, could we delete circle UI element.

brandonroberts · 2023-02-16T14:52:16Z

This section is meant to share totals PRs represented in the topic. If that is not possible, could we delete circle UI element.

I think we should remove it for now

lib/hooks/useTopicOptions.ts

components/molecules/FilterCardSelect/filter-card-select.tsx

nightknighto · 2023-02-16T19:40:25Z

This section is meant to share totals PRs represented in the topic. If that is not possible, could we delete circle UI element.

deleted

## [1.30.0-beta.3](v1.30.0-beta.2...v1.30.0-beta.3) (2023-02-17) ### 🍕 Features * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533)

github-actions · 2023-02-17T16:23:21Z

🎉 This PR is included in version 1.30.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.30.0-alpha.2](v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### 🍕 Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### 🐛 Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](f4cc62f)) * formatting ([065ede0](065ede0)) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)

github-actions · 2023-02-17T21:55:36Z

🎉 This PR is included in version 1.30.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.30.0](v1.29.0...v1.30.0) (2023-02-21) ### 🍕 Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### 🐛 Bug Fixes * disable create page button only if insight page name is empty ([#893](#893)) ([ed52399](ed52399)), closes [#892](#892) * hide non-functional elements in highlights card ([#881](#881)) ([ba1bd5e](ba1bd5e)) * rename 404 image file ([4e5171f](4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](#889)) ([3bfc5a4](3bfc5a4)), closes [#883](#883) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858) * user profile interest pill UI fix ([#890](#890)) ([4cbff36](4cbff36))

github-actions · 2023-02-21T17:20:44Z

🎉 This PR is included in version 1.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.30.0-beta.3](open-sauced/app@v1.30.0-beta.2...v1.30.0-beta.3) (2023-02-17) ### 🍕 Features * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533)

## [1.30.0-alpha.2](open-sauced/app@v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### 🍕 Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### 🐛 Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](open-sauced/app@f4cc62f)) * formatting ([065ede0](open-sauced/app@065ede0)) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)

## [1.30.0](open-sauced/app@v1.29.0...v1.30.0) (2023-02-21) ### 🍕 Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### 🐛 Bug Fixes * disable create page button only if insight page name is empty ([#893](open-sauced/app#893)) ([ed52399](open-sauced/app@ed52399)), closes [#892](open-sauced/app#892) * hide non-functional elements in highlights card ([#881](open-sauced/app#881)) ([ba1bd5e](open-sauced/app@ba1bd5e)) * rename 404 image file ([4e5171f](open-sauced/app@4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](open-sauced/app#889)) ([3bfc5a4](open-sauced/app@3bfc5a4)), closes [#883](open-sauced/app#883) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858) * user profile interest pill UI fix ([#890](open-sauced/app#890)) ([4cbff36](open-sauced/app@4cbff36))

nightknighto added 3 commits February 15, 2023 16:43

refractor: rename checkCamelCase lib

2259fd4

feat: add dropdown selection for topics

6581921

feat: add pointer cursor

4bc1596

nightknighto added 3 commits February 15, 2023 17:17

fix: improve mobile view

84e0c46

test: add storybook

2bc4fa6

lint

3d093b6

nightknighto marked this pull request as ready for review February 15, 2023 18:14

bdougie requested changes Feb 15, 2023

View reviewed changes

brandonroberts requested changes Feb 16, 2023

View reviewed changes

lib/hooks/useTopicOptions.ts Outdated Show resolved Hide resolved

components/molecules/FilterCardSelect/filter-card-select.tsx Outdated Show resolved Hide resolved

nightknighto added 3 commits February 16, 2023 19:20

fix: remove glowing circle

32f8731

refractor: rename getTopicsOptions

0ef810f

refractor: change type

ce8b546

nightknighto requested review from brandonroberts and bdougie February 16, 2023 17:39

bdougie approved these changes Feb 17, 2023

View reviewed changes

brandonroberts approved these changes Feb 17, 2023

View reviewed changes

brandonroberts merged commit 9579902 into beta Feb 17, 2023

brandonroberts deleted the 533-constrain-available-topics-to-predefined-list branch February 17, 2023 16:17

github-actions bot added the released on @beta label Feb 17, 2023

github-actions bot added the released on @alpha label Feb 17, 2023

github-actions bot added the released label Feb 21, 2023

bdougie mentioned this pull request Jul 14, 2023

Feature: Add new topics to the list #1355

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add dropdown for topics in Explore #877

feat: add dropdown for topics in Explore #877

nightknighto commented Feb 15, 2023 •

edited

Loading

netlify bot commented Feb 15, 2023 •

edited

Loading

netlify bot commented Feb 15, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading

brandonroberts commented Feb 16, 2023

nightknighto commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

feat: add dropdown for topics in Explore #877

feat: add dropdown for topics in Explore #877

Conversation

nightknighto commented Feb 15, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Follow-up tasks

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Feb 15, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Feb 15, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

brandonroberts commented Feb 16, 2023

nightknighto commented Feb 16, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

nightknighto commented Feb 15, 2023 •

edited

Loading

netlify bot commented Feb 15, 2023 •

edited

Loading

netlify bot commented Feb 15, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading