refactor: remove hard-coded height from layouts #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0916dhkim
changed the title
|
Thanks @0916dhkim, will you provide some before/after screenshots regarding this change? |
|
@brandonroberts Yes, this is the screenshot, but the idea was to only remove the hard coded values without affecting the existing layouts. The pages should look the same as before. |
The screenshot is still needed in this case. It is confirmation that you checked and provides an example for the reviewer to check as well. |
brandonroberts
approved these changes
Jun 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
## [1.52.0-beta.5](v1.52.0-beta.4...v1.52.0-beta.5) (2023-06-15) ### 🐛 Bug Fixes * remove hard-coded height from layouts ([#1257](#1257)) ([20061bc](20061bc))
|
🎉 This PR is included in version 1.52.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
## [1.52.0](v1.51.0...v1.52.0) (2023-06-15) ### 🍕 Features * add openGraph image to public insight pages ([#1258](#1258)) ([f0a7f7e](f0a7f7e)) * implement user collaboration features ([#1221](#1221)) ([00b6d1a](00b6d1a)) ### 🐛 Bug Fixes * add session check before redirecting in private wrapper component ([#1261](#1261)) ([891e4c9](891e4c9)), closes [#1260](#1260) * remove duplicate redirect check and use server props on insight page ([#1255](#1255)) ([9ef2780](9ef2780)) * remove hard-coded height from layouts ([#1257](#1257)) ([20061bc](20061bc))
|
🎉 This PR is included in version 1.52.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
codewithshariq
added a commit
to codewithshariq/insights
that referenced
this pull request
Jun 21, 2023
codewithshariq
added a commit
to codewithshariq/insights
that referenced
this pull request
Jun 22, 2023
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.52.0-beta.5](open-sauced/app@v1.52.0-beta.4...v1.52.0-beta.5) (2023-06-15) ### 🐛 Bug Fixes * remove hard-coded height from layouts ([#1257](open-sauced/app#1257)) ([20061bc](open-sauced/app@20061bc))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.52.0](open-sauced/app@v1.51.0...v1.52.0) (2023-06-15) ### 🍕 Features * add openGraph image to public insight pages ([#1258](open-sauced/app#1258)) ([f0a7f7e](open-sauced/app@f0a7f7e)) * implement user collaboration features ([#1221](open-sauced/app#1221)) ([00b6d1a](open-sauced/app@00b6d1a)) ### 🐛 Bug Fixes * add session check before redirecting in private wrapper component ([#1261](open-sauced/app#1261)) ([891e4c9](open-sauced/app@891e4c9)), closes [#1260](open-sauced/app#1260) * remove duplicate redirect check and use server props on insight page ([#1255](open-sauced/app#1255)) ([9ef2780](open-sauced/app@9ef2780)) * remove hard-coded height from layouts ([#1257](open-sauced/app#1257)) ([20061bc](open-sauced/app@20061bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Refactor the layout components so that there are no hard-coded values.
Related Tickets & Documents
Fixes #175
Mobile & Desktop Screenshots/Recordings
The layout should not change from this change.
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?