-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement user collaboration features #1221
Conversation
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@brandonroberts any chance we can implement feature flagging for this feature? I really think the UI is ready for prime time, but it would be nice to show the feature behind the scenes. Perhaps we can make this for paid users only for now. |
β¦19-collaboration-workflow
@bdougie yes, we can use the same logic for determining access to reports to restrict seeing this. We can land this and follow-up with the role check. |
components/molecules/ContributorProfileHeader/contributor-profile-header.tsx
Show resolved
Hide resolved
components/molecules/ContributorProfileHeader/contributor-profile-header.tsx
Outdated
Show resolved
Hide resolved
components/organisms/CollaborationRequestWrapper/collaboration-requests-wrapper.tsx
Outdated
Show resolved
Hide resolved
components/organisms/CollaborationRequestWrapper/collaboration-requests-wrapper.tsx
Show resolved
Hide resolved
We need it on desktop. 3 buttons is a bit much. We will ultimately need a better design eventually, but the dropdown works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per slack, we need to add a "paid user" feature flag for the collaboration button. This will allow us to test the feature and iterate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
β¦19-collaboration-workflow
β¦sauced/insights into 719-collaboration-workflow
## [1.52.0-beta.1](v1.51.0...v1.52.0-beta.1) (2023-06-07) ### π Features * implement user collaboration features ([#1221](#1221)) ([00b6d1a](00b6d1a))
π This PR is included in version 1.52.0-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.52.0](v1.51.0...v1.52.0) (2023-06-15) ### π Features * add openGraph image to public insight pages ([#1258](#1258)) ([f0a7f7e](f0a7f7e)) * implement user collaboration features ([#1221](#1221)) ([00b6d1a](00b6d1a)) ### π Bug Fixes * add session check before redirecting in private wrapper component ([#1261](#1261)) ([891e4c9](891e4c9)), closes [#1260](#1260) * remove duplicate redirect check and use server props on insight page ([#1255](#1255)) ([9ef2780](9ef2780)) * remove hard-coded height from layouts ([#1257](#1257)) ([20061bc](20061bc))
π This PR is included in version 1.52.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.52.0-beta.1](open-sauced/app@v1.51.0...v1.52.0-beta.1) (2023-06-07) ### π Features * implement user collaboration features ([#1221](open-sauced/app#1221)) ([00b6d1a](open-sauced/app@00b6d1a))
## [1.52.0](open-sauced/app@v1.51.0...v1.52.0) (2023-06-15) ### π Features * add openGraph image to public insight pages ([#1258](open-sauced/app#1258)) ([f0a7f7e](open-sauced/app@f0a7f7e)) * implement user collaboration features ([#1221](open-sauced/app#1221)) ([00b6d1a](open-sauced/app@00b6d1a)) ### π Bug Fixes * add session check before redirecting in private wrapper component ([#1261](open-sauced/app#1261)) ([891e4c9](open-sauced/app@891e4c9)), closes [#1260](open-sauced/app#1260) * remove duplicate redirect check and use server props on insight page ([#1255](open-sauced/app#1255)) ([9ef2780](open-sauced/app@9ef2780)) * remove hard-coded height from layouts ([#1257](open-sauced/app#1257)) ([20061bc](open-sauced/app@20061bc))
What type of PR is this? (check all applicable)
Description
This PR:
Related Tickets & Documents
Closes #719
Closes #1003
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?