Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add session check before redirecting in private wrapper component #1261

Merged
merged 1 commit into from Jun 13, 2023

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Jun 12, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Fixes an issue with reloading on auth protected pages, where the initial user on page load is empty.

Related Tickets & Documents

Closes #1260

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jun 12, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 3f6356e
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/648768bd2068d90008872574
😎 Deploy Preview https://deploy-preview-1261--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 12, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 3f6356e
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/648768bd8344aa00086e8ac7
😎 Deploy Preview https://deploy-preview-1261--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@brandonroberts brandonroberts merged commit 891e4c9 into beta Jun 13, 2023
17 checks passed
@brandonroberts brandonroberts deleted the fix-redirect-private-route branch June 13, 2023 02:00
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
## [1.52.0-beta.3](v1.52.0-beta.2...v1.52.0-beta.3) (2023-06-13)

### πŸ› Bug Fixes

* add session check before redirecting in private wrapper component ([#1261](#1261)) ([891e4c9](891e4c9)), closes [#1260](#1260)
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.52.0-beta.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 15, 2023
## [1.52.0](v1.51.0...v1.52.0) (2023-06-15)

### πŸ• Features

* add openGraph image to public insight pages ([#1258](#1258)) ([f0a7f7e](f0a7f7e))
* implement user collaboration features ([#1221](#1221)) ([00b6d1a](00b6d1a))

### πŸ› Bug Fixes

* add session check before redirecting in private wrapper component ([#1261](#1261)) ([891e4c9](891e4c9)), closes [#1260](#1260)
* remove duplicate redirect check and use server props on insight page ([#1255](#1255)) ([9ef2780](9ef2780))
* remove hard-coded height from layouts ([#1257](#1257)) ([20061bc](20061bc))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.52.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.52.0-beta.3](open-sauced/app@v1.52.0-beta.2...v1.52.0-beta.3) (2023-06-13)

### πŸ› Bug Fixes

* add session check before redirecting in private wrapper component ([#1261](open-sauced/app#1261)) ([891e4c9](open-sauced/app@891e4c9)), closes [#1260](open-sauced/app#1260)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.52.0](open-sauced/app@v1.51.0...v1.52.0) (2023-06-15)

### πŸ• Features

* add openGraph image to public insight pages ([#1258](open-sauced/app#1258)) ([f0a7f7e](open-sauced/app@f0a7f7e))
* implement user collaboration features ([#1221](open-sauced/app#1221)) ([00b6d1a](open-sauced/app@00b6d1a))

### πŸ› Bug Fixes

* add session check before redirecting in private wrapper component ([#1261](open-sauced/app#1261)) ([891e4c9](open-sauced/app@891e4c9)), closes [#1260](open-sauced/app#1260)
* remove duplicate redirect check and use server props on insight page ([#1255](open-sauced/app#1255)) ([9ef2780](open-sauced/app@9ef2780))
* remove hard-coded height from layouts ([#1257](open-sauced/app#1257)) ([20061bc](open-sauced/app@20061bc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When doing a page reload on a private route, the page is redirect to the public explore page
3 participants