Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… #1387

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

aryanas159
Copy link
Contributor

@aryanas159 aryanas159 commented Jul 18, 2023

…s Page

Description

fixes #1386
Added a useRef and activated the scrollIntoView method when changing pages.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
Untitled.video.-.Made.with.Clipchamp.8.mp4
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

…s Page

Signed-off-by: Aryan Singh <ssaryans597@gmail.com>
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7089382
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64b626d880ccd90008de4d7a
😎 Deploy Preview https://deploy-preview-1387--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 7089382
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64b626d8b859320008c66aaa
😎 Deploy Preview https://deploy-preview-1387--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryanas159 aryanas159 removed their assignment Jul 18, 2023
@brandonroberts brandonroberts added the needs review PRs that need review from core engineering team label Jul 18, 2023
Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aryanas159, LGTM 🍕

@OgDev-01 OgDev-01 requested a review from bdougie July 18, 2023 14:58
@OgDev-01 OgDev-01 added needs-approval and removed needs review PRs that need review from core engineering team labels Jul 18, 2023
Copy link
Contributor

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🍕

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this.

@bdougie bdougie merged commit 77b161d into open-sauced:beta Jul 18, 2023
29 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.56.1-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
### [1.56.1-beta.3](v1.56.1-beta.2...v1.56.1-beta.3) (2023-07-18)

### 🐛 Bug Fixes

* Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d))
@aryanas159 aryanas159 deleted the issue-#1386 branch July 20, 2023 04:45
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24)

### 🤖 Build System

* update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276))

### 🔁 Continuous Integration

* disable husky for release ([2537649](2537649))
* fix husky command during release ([3e493a2](3e493a2))

### 🐛 Bug Fixes

* add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46))
* Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d))
* flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14))
* Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4))
* Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7))
* Move card image api route ([#1401](#1401)) ([d650161](d650161))
* update top contributors response data ([#1397](#1397)) ([9053091](9053091))

### 🍕 Features

* add `[#100](#100 challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf))
* add 404 page ([#1390](#1390)) ([37bd475](37bd475))
* add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b))
* Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80))
* add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4))
* implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576))
* implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlights Page
5 participants