Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add #100DayOfOSS challenge anouncement to feeds #1389

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

OgDev-01
Copy link
Contributor

Description

This PR adds the open-sauced #100DaysOfOSS challenge announcement to the feeds page and updates component naming, props and styles to fit its use.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #1388

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 18, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit afd76e4
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64b6e7544e08cd0007b2318a
😎 Deploy Preview https://deploy-preview-1389--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 18, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit afd76e4
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64b6e7548069c50008731ae2
😎 Deploy Preview https://deploy-preview-1389--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 changed the title feat: add `#100DayOfOSS anouncement to feeds feat: add #100DayOfOSS challenge anouncement to feeds Jul 18, 2023
@bdougie
Copy link
Member

bdougie commented Jul 18, 2023

Can darken the image. Either use this, or add a black square with 15% opacity. Finding the white contrast with the site's grey hard to look at.

Group 9 (1)

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Jul 18, 2023

This still doesn't look quite ok to me, but it is better compared to the prev
image

@bdougie
Copy link
Member

bdougie commented Jul 18, 2023

This still doesn't look quite ok to me image

Let's just role with the original and perhaps get @chhristopher to create to something else later. Probably just one light mode friendly.

@OgDev-01. feel free to merge when you revert back to the first one.

@OgDev-01 OgDev-01 merged commit 751dbbf into beta Jul 18, 2023
11 checks passed
@OgDev-01 OgDev-01 deleted the 1388-anouncement-card branch July 18, 2023 19:31
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
## [1.57.0-beta.1](v1.56.1-beta.3...v1.57.0-beta.1) (2023-07-18)

### πŸ• Features

* add `[#100](#100 challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.57.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@chhristopher
Copy link

@bdougie @OgDev-01 agreed, i'll look into having something that plays nice with everything else on the page

github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24)

### πŸ€– Build System

* update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276))

### πŸ” Continuous Integration

* disable husky for release ([2537649](2537649))
* fix husky command during release ([3e493a2](3e493a2))

### πŸ› Bug Fixes

* add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46))
* Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d))
* flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14))
* Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4))
* Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7))
* Move card image api route ([#1401](#1401)) ([d650161](d650161))
* update top contributors response data ([#1397](#1397)) ([9053091](9053091))

### πŸ• Features

* add `[#100](#100 challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf))
* add 404 page ([#1390](#1390)) ([37bd475](37bd475))
* add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b))
* Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80))
* add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4))
* implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576))
* implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: AnnouncementCard
4 participants