fix: factor pullrequestLink into HighlightInput form isDivFocused condition
#1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Jul 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
## [1.57.0-beta.5](v1.57.0-beta.4...v1.57.0-beta.5) (2023-07-24) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46))
|
🎉 This PR is included in version 1.57.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2)) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46)) * Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d)) * flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14)) * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4)) * Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7)) * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🍕 Features * add `[#100](#100 challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf)) * add 404 page ([#1390](#1390)) ([37bd475](37bd475)) * add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b)) * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) * implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
babblebey
deleted the
fix--factor-pullrequestLink-into-HighlightInput-display-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Factors in the
pullrequestLinkintoHighlightInputformisDivFocusedcondition which is in charge of the toggle behaviour triggered by the Title Field of theHighlightInput.Now the Title field conditionally hides the other form fields only when the Description or Pull Request Link field has zero content.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1405
Mobile & Desktop Screenshots/Recordings
screencast-localhost_3000-2023.07.22-18_48_13.webm
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
NA
[optional] What gif best describes this PR or how it makes you feel?