Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now workspace settings and new page have a fixed footer for CTAs #2982

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Mar 20, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #2924

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-03-20 at 10 08 59

image

After

Settings Page

CleanShot 2024-03-20 at 10 07 25

CleanShot 2024-03-20 at 09 55 04

New Workspace Page

CleanShot 2024-03-20 at 09 56 01

Steps to QA

  1. Go to your workspace settings page, e.g. /workspaces/some-worspace-id/settings
  2. Scroll through the settings.
  3. Notice the Update workspace button remains in a fixed footer and content scrolls underneath it.
  4. Do the same thing for the create new workspace page, /workspaces/new, and the same behaviour occurs.

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Mar 20, 2024

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 125e77f
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/65faeedb96043400081178c8
😎 Deploy Preview https://deploy-preview-2982--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2024

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 125e77f
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/65faeedb437c3000074294a4
😎 Deploy Preview https://deploy-preview-2982--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from isabensusan, zeucapua and jpmcb and removed request for isabensusan March 20, 2024 14:02
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'd - looks great!! πŸ‘πŸΌ

@isabensusan
Copy link
Member

QA'd it and it looks great!! I'll open a separate ticket to add the same interaction to Repo/Contributor insights

@nickytonline nickytonline merged commit 7fff9fa into beta Mar 20, 2024
12 checks passed
@nickytonline nickytonline deleted the nickytonline/fixed-footer-workspaces branch March 20, 2024 15:27
open-sauced bot pushed a commit that referenced this pull request Mar 20, 2024
## [2.9.0-beta.10](v2.9.0-beta.9...v2.9.0-beta.10) (2024-03-20)

### πŸ› Bug Fixes

* now workspace settings and new page have a fixed footer for CTAs ([#2982](#2982)) ([7fff9fa](7fff9fa))
open-sauced bot pushed a commit that referenced this pull request Mar 21, 2024
## [2.10.0-beta.1](v2.9.0...v2.10.0-beta.1) (2024-03-21)

### πŸ§‘β€πŸ’» Code Refactoring

* move [pageId] pages to dedicated /explore/topic route ([#2974](#2974)) ([bd449a4](bd449a4))

### πŸ› Bug Fixes

* add workspace welcome modal image ([#2971](#2971)) ([857954f](857954f))
* now workspace settings and new page have a fixed footer for CTAs ([#2982](#2982)) ([7fff9fa](7fff9fa))
* now you can use free text to select an organization for tracking repos ([#2972](#2972)) ([ab0438a](ab0438a))
* track bulk add input for Tracked Wizard Modal in localStorage ([#2976](#2976)) ([77ed601](77ed601))

### πŸ• Features

* bump to 2.10.0 ([#2999](#2999)) ([0bc4f3e](0bc4f3e))
* drawer component ([#2992](#2992)) ([ea686a8](ea686a8))
* replace outside click to button for tracked modal ([#2980](#2980)) ([7049199](7049199))
* use URL shortener when Share button is used ([#2990](#2990)) ([f237b2b](f237b2b))
open-sauced bot pushed a commit that referenced this pull request Mar 21, 2024
## [2.10.0](v2.9.0...v2.10.0) (2024-03-21)

### πŸ§‘β€πŸ’» Code Refactoring

* move [pageId] pages to dedicated /explore/topic route ([#2974](#2974)) ([bd449a4](bd449a4))

### πŸ› Bug Fixes

* add workspace welcome modal image ([#2971](#2971)) ([857954f](857954f))
* now workspace settings and new page have a fixed footer for CTAs ([#2982](#2982)) ([7fff9fa](7fff9fa))
* now you can use free text to select an organization for tracking repos ([#2972](#2972)) ([ab0438a](ab0438a))
* track bulk add input for Tracked Wizard Modal in localStorage ([#2976](#2976)) ([77ed601](77ed601))

### πŸ• Features

* bump to 2.10.0 ([#2999](#2999)) ([0bc4f3e](0bc4f3e))
* drawer component ([#2992](#2992)) ([ea686a8](ea686a8))
* replace outside click to button for tracked modal ([#2980](#2980)) ([7049199](7049199))
* use URL shortener when Share button is used ([#2990](#2990)) ([f237b2b](f237b2b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Button that saves a repository to workspace floats to bottom of page
3 participants