Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed a regression with workspaces not updating/creating #3003

Merged
merged 1 commit into from Mar 21, 2024
Merged

fix: fixed a regression with workspaces not updating/creating #3003

merged 1 commit into from Mar 21, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Mar 21, 2024 •
edited

Description

Fixes a regression by the submit button for creating and updating workspaces was no longer in the form. The fix leverages the button form attribute.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Relatest to #2982

Mobile & Desktop Screenshots/Recordings

Steps to QA

Create a workspace

  1. Go to /workspaces/new
  2. Enter a name, description optional.
  3. Click on the Create Workspace button.
  4. The workspace is created.

Update a workspace

  1. Go to /workspaces/some-workspace-id/settings.
  2. Update something about the workspace.
  3. Click the Update Workspace button.
  4. The workspace updates.

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit bc7bfaa
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/65fcab5f8caac50008aac4c3
😎 Deploy Preview https://deploy-preview-3003--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit bc7bfaa
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/65fcab5f9fa3fc0008a179ce
😎 Deploy Preview https://deploy-preview-3003--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from isabensusan and a team March 21, 2024 21:49
zeucapua
zeucapua approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@zeucapua zeucapua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickytonline nickytonline requested a review from jpmcb March 21, 2024 21:59
@nickytonline nickytonline merged commit d3194b9 into beta Mar 21, 2024
42 checks passed
@nickytonline nickytonline deleted the nickytonline/link-update-save-button-to-form branch March 21, 2024 22:12
open-sauced bot pushed a commit that referenced this pull request Mar 21, 2024
@nickytonline @open-sauced
chore(patch): release 2.10.1-beta.1 on beta channel [skip ci]
0967db0 
## [2.10.1-beta.1](v2.10.0...v2.10.1-beta.1) (2024-03-21)

### 🐛 Bug Fixes

* fixed a regression with workspaces not updating/creating ([bc7bfaa](bc7bfaa))
* fixed a regression with workspaces not updating/creating ([#3003](#3003)) ([d3194b9](d3194b9))
open-sauced bot pushed a commit that referenced this pull request Mar 21, 2024
@nickytonline @open-sauced
chore(patch): release 2.10.1 [skip ci]
6d501bc 
## [2.10.1](v2.10.0...v2.10.1) (2024-03-21)

### 🐛 Bug Fixes

* fixed a regression with workspaces not updating/creating ([bc7bfaa](bc7bfaa))
* fixed a regression with workspaces not updating/creating ([#3003](#3003)) ([d3194b9](d3194b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeucapua zeucapua zeucapua approved these changes

@jpmcb jpmcb jpmcb approved these changes

@isabensusan isabensusan Awaiting requested review from isabensusan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickytonline @zeucapua @jpmcb