Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tooltip message on information icon hover #421

Merged
merged 2 commits into from
Sep 22, 2022
Merged

fix: add tooltip message on information icon hover #421

merged 2 commits into from
Sep 22, 2022

Conversation

OgDev-01
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR adds a tooltip message on the information icon hover in show outside contributors

Don't really know if this is the expected result though 🙏🙏. just decided to give it a try

Related Tickets & Documents

Fixes #366

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit cb7abb6
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/632c9f14e7b2d10009dbf2f7
😎 Deploy Preview https://deploy-preview-421--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Sep 22, 2022
@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit cb7abb6
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/632c9f14feb98100087c6a55
😎 Deploy Preview https://deploy-preview-421--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts added ready-to-merge and removed needs review PRs that need review from core engineering team labels Sep 22, 2022
0-vortex
0-vortex reviewed Sep 22, 2022
View reviewed changes
components/atoms/ToggleOption/toggle-option.tsx Outdated
{withIcon && <HiInformationCircle className="text-light-slate-9" />}
{withIcon && (
<HiInformationCircle
title="An outside contributor is a person who is not a member of repositories/organization"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "not a member of your organization" ?

Copy link
Contributor Author

@OgDev-01 OgDev-01 Sep 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdougie what's do you think about this?

Should this be "not a member of your organization" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "the organiztion"

@bdougie bdougie merged commit 12ff851 into beta Sep 22, 2022
@bdougie bdougie deleted the 366-show-outside-contributors branch September 22, 2022 17:51
github-actions bot pushed a commit that referenced this pull request Sep 22, 2022
@OgDev-01 @open-sauced
chore(patch): release 1.7.0-beta.4 on beta channel [skip ci]
8ed605d 
## [1.7.0-beta.4](v1.7.0-beta.3...v1.7.0-beta.4) (2022-09-22)

### 🐛 Bug Fixes

* add tooltip message on information icon hover ([#421](#421)) ([12ff851](12ff851)), closes [#366](#366)
@github-actions
Copy link

🎉 This PR is included in version 1.7.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
@bdougie @open-sauced
chore(minor): release 1.7.0 [skip ci]
9cc9f2a 
## [1.7.0](v1.6.0...v1.7.0) (2022-09-23)

### 🎨 Styles

* added hover state style to footer links ([#420](#420)) ([3aa5f17](3aa5f17))
* change text font and icon size to xs(12px) ([#401](#401)) ([741288e](741288e))
* refactor show us button style to match design ([#419](#419)) ([b6c21b1](b6c21b1)), closes [#408](#408)

### 🐛 Bug Fixes

* add tooltip message on information icon hover ([#421](#421)) ([12ff851](12ff851)), closes [#366](#366)
* adds brandon to top5 ([8bb56cb](8bb56cb))
* correct beta branch checking beta gitsense api ([2c6f576](2c6f576))
* redirect from onboarding if already complete with custom hook ([#388](#388)) ([8600c76](8600c76)), closes [#387](#387)
* update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](#423)) ([05b48ff](05b48ff)), closes [#418](#418)

### 🍕 Features

* add privacy and license terms ([#422](#422)) ([0dcc161](0dcc161)), closes [#377](#377)
* connect repositories page to API data and pagination ([#405](#405)) ([634de8e](634de8e)), closes [#320](#320) [#384](#384)
* create mobile version of repo table ([#409](#409)) ([9355968](9355968))

### 🧑‍💻 Code Refactoring

* check avatarURL for orange avatar background and update pill colors ([#424](#424)) ([c821cd5](c821cd5)), closes [#414](#414) [#416](#416)
* Polish the Dashboard to match designs ([#427](#427)) ([f919c27](f919c27))
* Polish the Reports Page to match the design ([#425](#425)) ([87a2bdc](87a2bdc))
* Update text styles on Scatter Chart card ([#429](#429)) ([ab24703](ab24703))
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
@ElpisHelle
chore(patch): release 1.7.0-beta.4 on beta channel [skip ci]
37f398a 
## [1.7.0-beta.4](open-sauced/app@v1.7.0-beta.3...v1.7.0-beta.4) (2022-09-22)

### 🐛 Bug Fixes

* add tooltip message on information icon hover ([#421](open-sauced/app#421)) ([12ff851](open-sauced/app@12ff851)), closes [#366](open-sauced/app#366)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
@ElpisHelle
chore(minor): release 1.7.0 [skip ci]
649e8ed 
## [1.7.0](open-sauced/app@v1.6.0...v1.7.0) (2022-09-23)

### 🎨 Styles

* added hover state style to footer links ([#420](open-sauced/app#420)) ([3aa5f17](open-sauced/app@3aa5f17))
* change text font and icon size to xs(12px) ([#401](open-sauced/app#401)) ([741288e](open-sauced/app@741288e))
* refactor show us button style to match design ([#419](open-sauced/app#419)) ([b6c21b1](open-sauced/app@b6c21b1)), closes [#408](open-sauced/app#408)

### 🐛 Bug Fixes

* add tooltip message on information icon hover ([#421](open-sauced/app#421)) ([12ff851](open-sauced/app@12ff851)), closes [#366](open-sauced/app#366)
* adds brandon to top5 ([8bb56cb](open-sauced/app@8bb56cb))
* correct beta branch checking beta gitsense api ([2c6f576](open-sauced/app@2c6f576))
* redirect from onboarding if already complete with custom hook ([#388](open-sauced/app#388)) ([8600c76](open-sauced/app@8600c76)), closes [#387](open-sauced/app#387)
* update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](open-sauced/app#423)) ([05b48ff](open-sauced/app@05b48ff)), closes [#418](open-sauced/app#418)

### 🍕 Features

* add privacy and license terms ([#422](open-sauced/app#422)) ([0dcc161](open-sauced/app@0dcc161)), closes [#377](open-sauced/app#377)
* connect repositories page to API data and pagination ([#405](open-sauced/app#405)) ([634de8e](open-sauced/app@634de8e)), closes [#320](open-sauced/app#320) [#384](open-sauced/app#384)
* create mobile version of repo table ([#409](open-sauced/app#409)) ([9355968](open-sauced/app@9355968))

### 🧑‍💻 Code Refactoring

* check avatarURL for orange avatar background and update pill colors ([#424](open-sauced/app#424)) ([c821cd5](open-sauced/app@c821cd5)), closes [#414](open-sauced/app#414) [#416](open-sauced/app#416)
* Polish the Dashboard to match designs ([#427](open-sauced/app#427)) ([f919c27](open-sauced/app@f919c27))
* Polish the Reports Page to match the design ([#425](open-sauced/app#425)) ([87a2bdc](open-sauced/app@87a2bdc))
* Update text styles on Scatter Chart card ([#429](open-sauced/app#429)) ([ab24703](open-sauced/app@ab24703))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0-vortex 0-vortex 0-vortex left review comments

@bdougie bdougie bdougie approved these changes

@brandonroberts brandonroberts brandonroberts approved these changes

@chadstewart chadstewart Awaiting requested review from chadstewart

@eryc-cc eryc-cc Awaiting requested review from eryc-cc

Assignees
No one assigned
Labels
ready-to-merge released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] There is no message when hovering over information icon in Show Outside Contributors
4 participants
@OgDev-01 @brandonroberts @0-vortex @bdougie