Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Polish the Dashboard to match designs #427

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Conversation

eryc-cc
Copy link
Contributor

@eryc-cc eryc-cc commented Sep 22, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR refactors the code that affects the dashboard in order to match the designs.

What this PR is doing:

  • Updated the Logo component: instead of loginScreen, we're now passing textIsBlack as a boolean prop.
  • Background colors for the navigation and main screen were updated to match the designs.
  • OnboardingButton was updated to look good on light backgrounds
  • Added a hover style to the ToolsNav link

Related Tickets & Documents

Resolves #374

Mobile & Desktop Screenshots/Recordings

Screen Shot 2022-09-22 at 5 39 38 PM

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 22, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 290e57a
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/632cc7eba7e1dc00099cbdc2
😎 Deploy Preview https://deploy-preview-427--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@eryc-cc eryc-cc changed the title enhancement: Polish the Dashboard to match designs refactor: Polish the Dashboard to match designs Sep 22, 2022
@netlify
Copy link

netlify bot commented Sep 22, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 290e57a
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/632cc7ebfc37fb0009b7575d
😎 Deploy Preview https://deploy-preview-427--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@eryc-cc eryc-cc marked this pull request as ready for review September 22, 2022 20:39
@eryc-cc eryc-cc self-assigned this Sep 22, 2022
@eryc-cc eryc-cc added the needs review PRs that need review from core engineering team label Sep 22, 2022
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

@eryc-cc eryc-cc merged commit f919c27 into beta Sep 22, 2022
@eryc-cc eryc-cc deleted the 374-polish-dashboard branch September 22, 2022 23:00
github-actions bot pushed a commit that referenced this pull request Sep 22, 2022
## [1.7.0-beta.6](v1.7.0-beta.5...v1.7.0-beta.6) (2022-09-22)

### πŸ§‘β€πŸ’» Code Refactoring

* Polish the Dashboard to match designs ([#427](#427)) ([f919c27](f919c27))
* Polish the Reports Page to match the design ([#425](#425)) ([87a2bdc](87a2bdc))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.7.0-beta.6 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
## [1.7.0](v1.6.0...v1.7.0) (2022-09-23)

### 🎨 Styles

* added hover state style to footer links ([#420](#420)) ([3aa5f17](3aa5f17))
* change text font and icon size to xs(12px) ([#401](#401)) ([741288e](741288e))
* refactor show us button style to match design ([#419](#419)) ([b6c21b1](b6c21b1)), closes [#408](#408)

### πŸ› Bug Fixes

* add tooltip message on information icon hover ([#421](#421)) ([12ff851](12ff851)), closes [#366](#366)
* adds brandon to top5 ([8bb56cb](8bb56cb))
* correct beta branch checking beta gitsense api ([2c6f576](2c6f576))
* redirect from onboarding if already complete with custom hook ([#388](#388)) ([8600c76](8600c76)), closes [#387](#387)
* update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](#423)) ([05b48ff](05b48ff)), closes [#418](#418)

### πŸ• Features

* add privacy and license terms ([#422](#422)) ([0dcc161](0dcc161)), closes [#377](#377)
* connect repositories page to API data and pagination ([#405](#405)) ([634de8e](634de8e)), closes [#320](#320) [#384](#384)
* create mobile version of repo table ([#409](#409)) ([9355968](9355968))

### πŸ§‘β€πŸ’» Code Refactoring

* check avatarURL for orange avatar background and update pill colors ([#424](#424)) ([c821cd5](c821cd5)), closes [#414](#414) [#416](#416)
* Polish the Dashboard to match designs ([#427](#427)) ([f919c27](f919c27))
* Polish the Reports Page to match the design ([#425](#425)) ([87a2bdc](87a2bdc))
* Update text styles on Scatter Chart card ([#429](#429)) ([ab24703](ab24703))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.7.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.7.0-beta.6](open-sauced/app@v1.7.0-beta.5...v1.7.0-beta.6) (2022-09-22)

### πŸ§‘β€πŸ’» Code Refactoring

* Polish the Dashboard to match designs ([#427](open-sauced/app#427)) ([f919c27](open-sauced/app@f919c27))
* Polish the Reports Page to match the design ([#425](open-sauced/app#425)) ([87a2bdc](open-sauced/app@87a2bdc))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.7.0](open-sauced/app@v1.6.0...v1.7.0) (2022-09-23)

### 🎨 Styles

* added hover state style to footer links ([#420](open-sauced/app#420)) ([3aa5f17](open-sauced/app@3aa5f17))
* change text font and icon size to xs(12px) ([#401](open-sauced/app#401)) ([741288e](open-sauced/app@741288e))
* refactor show us button style to match design ([#419](open-sauced/app#419)) ([b6c21b1](open-sauced/app@b6c21b1)), closes [#408](open-sauced/app#408)

### πŸ› Bug Fixes

* add tooltip message on information icon hover ([#421](open-sauced/app#421)) ([12ff851](open-sauced/app@12ff851)), closes [#366](open-sauced/app#366)
* adds brandon to top5 ([8bb56cb](open-sauced/app@8bb56cb))
* correct beta branch checking beta gitsense api ([2c6f576](open-sauced/app@2c6f576))
* redirect from onboarding if already complete with custom hook ([#388](open-sauced/app#388)) ([8600c76](open-sauced/app@8600c76)), closes [#387](open-sauced/app#387)
* update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](open-sauced/app#423)) ([05b48ff](open-sauced/app@05b48ff)), closes [#418](open-sauced/app#418)

### πŸ• Features

* add privacy and license terms ([#422](open-sauced/app#422)) ([0dcc161](open-sauced/app@0dcc161)), closes [#377](open-sauced/app#377)
* connect repositories page to API data and pagination ([#405](open-sauced/app#405)) ([634de8e](open-sauced/app@634de8e)), closes [#320](open-sauced/app#320) [#384](open-sauced/app#384)
* create mobile version of repo table ([#409](open-sauced/app#409)) ([9355968](open-sauced/app@9355968))

### πŸ§‘β€πŸ’» Code Refactoring

* check avatarURL for orange avatar background and update pill colors ([#424](open-sauced/app#424)) ([c821cd5](open-sauced/app@c821cd5)), closes [#414](open-sauced/app#414) [#416](open-sauced/app#416)
* Polish the Dashboard to match designs ([#427](open-sauced/app#427)) ([f919c27](open-sauced/app@f919c27))
* Polish the Reports Page to match the design ([#425](open-sauced/app#425)) ([87a2bdc](open-sauced/app@87a2bdc))
* Update text styles on Scatter Chart card ([#429](open-sauced/app#429)) ([ab24703](open-sauced/app@ab24703))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Latest polishes before Hacktoberfest
3 participants