-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update PR overview calculation to use active PRs in last 30 days / total PRs #423
Conversation
β Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! π
Noticed the UI is off with the smaller %'s, but let's merge and deal with that on a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. open an issue for a UI thing
π This PR is included in version 1.7.0-beta.5 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.7.0](v1.6.0...v1.7.0) (2022-09-23) ### π¨ Styles * added hover state style to footer links ([#420](#420)) ([3aa5f17](3aa5f17)) * change text font and icon size to xs(12px) ([#401](#401)) ([741288e](741288e)) * refactor show us button style to match design ([#419](#419)) ([b6c21b1](b6c21b1)), closes [#408](#408) ### π Bug Fixes * add tooltip message on information icon hover ([#421](#421)) ([12ff851](12ff851)), closes [#366](#366) * adds brandon to top5 ([8bb56cb](8bb56cb)) * correct beta branch checking beta gitsense api ([2c6f576](2c6f576)) * redirect from onboarding if already complete with custom hook ([#388](#388)) ([8600c76](8600c76)), closes [#387](#387) * update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](#423)) ([05b48ff](05b48ff)), closes [#418](#418) ### π Features * add privacy and license terms ([#422](#422)) ([0dcc161](0dcc161)), closes [#377](#377) * connect repositories page to API data and pagination ([#405](#405)) ([634de8e](634de8e)), closes [#320](#320) [#384](#384) * create mobile version of repo table ([#409](#409)) ([9355968](9355968)) ### π§βπ» Code Refactoring * check avatarURL for orange avatar background and update pill colors ([#424](#424)) ([c821cd5](c821cd5)), closes [#414](#414) [#416](#416) * Polish the Dashboard to match designs ([#427](#427)) ([f919c27](f919c27)) * Polish the Reports Page to match the design ([#425](#425)) ([87a2bdc](87a2bdc)) * Update text styles on Scatter Chart card ([#429](#429)) ([ab24703](ab24703))
π This PR is included in version 1.7.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.7.0-beta.5](open-sauced/app@v1.7.0-beta.4...v1.7.0-beta.5) (2022-09-22) ### π Bug Fixes * update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](open-sauced/app#423)) ([05b48ff](open-sauced/app@05b48ff)), closes [#418](open-sauced/app#418)
## [1.7.0](open-sauced/app@v1.6.0...v1.7.0) (2022-09-23) ### π¨ Styles * added hover state style to footer links ([#420](open-sauced/app#420)) ([3aa5f17](open-sauced/app@3aa5f17)) * change text font and icon size to xs(12px) ([#401](open-sauced/app#401)) ([741288e](open-sauced/app@741288e)) * refactor show us button style to match design ([#419](open-sauced/app#419)) ([b6c21b1](open-sauced/app@b6c21b1)), closes [#408](open-sauced/app#408) ### π Bug Fixes * add tooltip message on information icon hover ([#421](open-sauced/app#421)) ([12ff851](open-sauced/app@12ff851)), closes [#366](open-sauced/app#366) * adds brandon to top5 ([8bb56cb](open-sauced/app@8bb56cb)) * correct beta branch checking beta gitsense api ([2c6f576](open-sauced/app@2c6f576)) * redirect from onboarding if already complete with custom hook ([#388](open-sauced/app#388)) ([8600c76](open-sauced/app@8600c76)), closes [#387](open-sauced/app#387) * update PR overview calculation to use active PRs in last 30 days / total PRs ([#423](open-sauced/app#423)) ([05b48ff](open-sauced/app@05b48ff)), closes [#418](open-sauced/app#418) ### π Features * add privacy and license terms ([#422](open-sauced/app#422)) ([0dcc161](open-sauced/app@0dcc161)), closes [#377](open-sauced/app#377) * connect repositories page to API data and pagination ([#405](open-sauced/app#405)) ([634de8e](open-sauced/app@634de8e)), closes [#320](open-sauced/app#320) [#384](open-sauced/app#384) * create mobile version of repo table ([#409](open-sauced/app#409)) ([9355968](open-sauced/app@9355968)) ### π§βπ» Code Refactoring * check avatarURL for orange avatar background and update pill colors ([#424](open-sauced/app#424)) ([c821cd5](open-sauced/app@c821cd5)), closes [#414](open-sauced/app#414) [#416](open-sauced/app#416) * Polish the Dashboard to match designs ([#427](open-sauced/app#427)) ([f919c27](open-sauced/app@f919c27)) * Polish the Reports Page to match the design ([#425](open-sauced/app#425)) ([87a2bdc](open-sauced/app@87a2bdc)) * Update text styles on Scatter Chart card ([#429](open-sauced/app#429)) ([ab24703](open-sauced/app@ab24703))
What type of PR is this? (check all applicable)
Description
This PR updates the PR overview calculation to use active PRs in the last 30 days / total PRs
Needs https://github.com/open-sauced/gs-api.opensauced.pizza/pull/26 to be merged on GS API side
Closes #418
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?