Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updated docs to retrieve auth token #280

Merged
merged 2 commits into from
Apr 11, 2024
Merged

docs: Updated docs to retrieve auth token #280

merged 2 commits into from
Apr 11, 2024

Conversation

OmkarPh
Copy link
Contributor

@OmkarPh OmkarPh commented Mar 18, 2024 •
edited
Loading

Description

This PR updates the docs from "Print auth token" to "Copy auth token" based on changes at open-sauced/hot#514.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #289
Implemented in open-sauced/hot#514

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@OmkarPh
Updated docs to retrieve auth token
3b3bf31 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh requested a review from a team as a code owner March 18, 2024 16:28
@netlify Netlify
Copy link

netlify bot commented Mar 18, 2024 •
edited
Loading

👷 Deploy request for docs-open pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 58c376a

github-actions[bot]
github-actions bot reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@OmkarPh OmkarPh changed the title Updated docs to retrieve auth token docs: Updated docs to retrieve auth token Mar 18, 2024
@OmkarPh OmkarPh mentioned this pull request Mar 18, 2024
Merged
16 tasks
@adiati98
Copy link
Member

Hi @OmkarPh

First of all, thank you for the PR! ✨️
I see that this PR is related to an issue in our hot repo.

However, an issue to update the docs is required for you to make any changes in this repo. Can you please create an issue for the purpose of updating the docs?

Based on our guidelines, PRs without link to any issue will be closed. And for that reason, we're closing this PR.

Feel free to create a new PR or ask us to reopen this PR once there's an issue accompanying the PR.

Also, we would like to confirm this changes/update from the @open-sauced/engineering team.

Thank you! 😊

@adiati98 adiati98 closed this Mar 18, 2024
@OmkarPh OmkarPh mentioned this pull request Apr 2, 2024
Closed
2 tasks
@adiati98 adiati98 reopened this Apr 3, 2024
@adiati98
Copy link
Member

adiati98 commented Apr 3, 2024

Hi @OmkarPh,

I've reopened your PR.

Please update the PR form as follow:

  • Let's make the description more descriptive:

    This PR updates the docs from "Print auth token" to "Copy auth token" based on changes at feat: Replaced print auth token with copy to clipboard hot#514.

  • Link your issue in the "Related Tickets and Documents" section instead of description.

  • As you can see, there's a bot here mentioning issue reference as part of PR complience. That's because GitHub only receives particular keywords. So, please use the prefix Closes when linking your issue.

adiati98
adiati98 requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OmkarPh,

I left a review here to be fixed. Thanks! 🙂

docs/contributing/set-up-authentication.md Outdated Show resolved Hide resolved
@OmkarPh
Fixed punctuation
58c376a 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh requested a review from adiati98 April 8, 2024 16:27
adiati98
adiati98 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
But I would like to have @BekahHW and @nickytonline second opinion on the content. 🙂

@nickytonline nickytonline merged commit a2b087c into open-sauced:main Apr 11, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@OmkarPh @open-sauced
chore(release): 1.72.0 [skip ci]
c49ce05 
## [1.72.0](v1.71.0...v1.72.0) (2024-04-11)

### Documentation

* Updated docs to retrieve auth token ([#280](#280)) ([a2b087c](a2b087c))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@nickytonline
docs: Updated docs to retrieve auth token (#280)
72e4e49 
* Updated docs to retrieve auth token

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

* Fixed punctuation

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>

---------

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com> a2b087c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@BekahHW BekahHW BekahHW approved these changes

@adiati98 adiati98 adiati98 approved these changes

Assignees

@OmkarPh OmkarPh

Labels
📝 documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Copy auth token in navbar
4 participants
@OmkarPh @adiati98 @BekahHW @nickytonline