feat: disable create page btn if the page name is missing #857

takanome-dev · 2023-02-09T17:59:04Z

What type of PR is this? (check all applicable)

Description

This PR:

adds a state to disable the create page button when the page name is not set or less than 3 characters
removes the state for tracking if the page name is set and displays an error after the form is submitted (not needed because the form can't be submitted without the page name being set)
adds disable classes to the submit button
cleanup of some explicit props set in the text-input atom

Related Tickets & Documents

Fixes #852

Mobile & Desktop Screenshots/Recordings

Empty state
Less than 3 characters
Valid

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-02-09T17:59:09Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`1f243ba`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63ebf4a060ecae0008b7c9eb
😎 Deploy Preview	https://deploy-preview-857--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…red-fields

netlify · 2023-02-10T00:41:19Z

✅ Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`1f243ba`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63ebf4a08c6615000831dda8
😎 Deploy Preview	https://deploy-preview-857--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandonroberts · 2023-02-10T19:50:42Z

@takanome-dev it works functionally, but UX wise it feels kind of weird that the button is enabled even if I clear out the name field, but then is disabled when I click on it. It would be better if the button was disabled when I clear it out also

takanome-dev · 2023-02-10T20:13:38Z

@takanome-dev it works functionally, but UX wise it feels kind of weird that the button is enabled even if I clear out the name field, but then is disabled when I click on it. It would be better if the button was disabled when I clear it out also

@brandonroberts yeah 💯 I didn't pay attention to that. Thanks for pointing that out.

Deadreyo

LGTM

0-vortex

LGTM! 👍

@brandonroberts can you take a 2nd look? Only doing tooling reviews lately

## [1.30.0-beta.1](v1.29.0...v1.30.0-beta.1) (2023-02-15) ### 🍕 Features * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852)

## [1.30.0-alpha.2](v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### 🍕 Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### 🐛 Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](f4cc62f)) * formatting ([065ede0](065ede0)) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858)

github-actions · 2023-02-17T21:55:39Z

🎉 This PR is included in version 1.30.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.30.0](v1.29.0...v1.30.0) (2023-02-21) ### 🍕 Features * add highlights to user profile page ([#859](#859)) ([4b01376](4b01376)), closes [#830](#830) * add dropdown for topics in Explore ([#877](#877)) ([9579902](9579902)), closes [#533](#533) * disable create insight page button if the page name is missing ([#857](#857)) ([95da564](95da564)), closes [#852](#852) ### 🐛 Bug Fixes * disable create page button only if insight page name is empty ([#893](#893)) ([ed52399](ed52399)), closes [#892](#892) * hide non-functional elements in highlights card ([#881](#881)) ([ba1bd5e](ba1bd5e)) * rename 404 image file ([4e5171f](4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](#889)) ([3bfc5a4](3bfc5a4)), closes [#883](#883) * reset text input fields when clear button is clicked ([#869](#869)) ([783098d](783098d)), closes [#858](#858) * user profile interest pill UI fix ([#890](#890)) ([4cbff36](4cbff36))

github-actions · 2023-02-21T17:20:53Z

🎉 This PR is included in version 1.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.30.0-beta.1](open-sauced/app@v1.29.0...v1.30.0-beta.1) (2023-02-15) ### 🍕 Features * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852)

## [1.30.0-alpha.2](open-sauced/app@v1.30.0-alpha.1...v1.30.0-alpha.2) (2023-02-17) ### 🍕 Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### 🐛 Bug Fixes * enable displaying/editing of insight page repos from API ([f4cc62f](open-sauced/app@f4cc62f)) * formatting ([065ede0](open-sauced/app@065ede0)) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858)

## [1.30.0](open-sauced/app@v1.29.0...v1.30.0) (2023-02-21) ### 🍕 Features * add highlights to user profile page ([#859](open-sauced/app#859)) ([4b01376](open-sauced/app@4b01376)), closes [#830](open-sauced/app#830) * add dropdown for topics in Explore ([#877](open-sauced/app#877)) ([9579902](open-sauced/app@9579902)), closes [#533](open-sauced/app#533) * disable create insight page button if the page name is missing ([#857](open-sauced/app#857)) ([95da564](open-sauced/app@95da564)), closes [#852](open-sauced/app#852) ### 🐛 Bug Fixes * disable create page button only if insight page name is empty ([#893](open-sauced/app#893)) ([ed52399](open-sauced/app@ed52399)), closes [#892](open-sauced/app#892) * hide non-functional elements in highlights card ([#881](open-sauced/app#881)) ([ba1bd5e](open-sauced/app@ba1bd5e)) * rename 404 image file ([4e5171f](open-sauced/app@4e5171f)) * replace `PRSocialCard` component with GitHub OpenGraph image ([#889](open-sauced/app#889)) ([3bfc5a4](open-sauced/app@3bfc5a4)), closes [#883](open-sauced/app#883) * reset text input fields when clear button is clicked ([#869](open-sauced/app#869)) ([783098d](open-sauced/app@783098d)), closes [#858](open-sauced/app#858) * user profile interest pill UI fix ([#890](open-sauced/app#890)) ([4cbff36](open-sauced/app@4cbff36))

refactor: disable create page btn if the page name is missing

7846d68

takanome-dev added 2 commits February 9, 2023 18:31

Merge remote-tracking branch 'origin/beta' into 852-create-page-requi…

b3e03fb

…red-fields

refactor: update text input atom

3e0a207

takanome-dev marked this pull request as ready for review February 9, 2023 18:32

takanome-dev requested review from OgDev-01, brandonroberts, 0-vortex and bdougie February 9, 2023 18:33

takanome-dev added the awaiting review label Feb 9, 2023

refactor: update input name validation

f73782c

brandonroberts approved these changes Feb 13, 2023

View reviewed changes

brandonroberts requested a review from Deadreyo February 13, 2023 17:09

takanome-dev mentioned this pull request Feb 13, 2023

fix: reset text input fields when clear button is clicked #869

Merged

19 tasks

fix: merge conflicts

1f243ba

Deadreyo approved these changes Feb 14, 2023

View reviewed changes

0-vortex approved these changes Feb 15, 2023

View reviewed changes

brandonroberts approved these changes Feb 15, 2023

View reviewed changes

brandonroberts merged commit 95da564 into open-sauced:beta Feb 15, 2023

takanome-dev deleted the 852-create-page-required-fields branch February 15, 2023 22:08

github-actions bot added the released on @alpha label Feb 17, 2023

github-actions bot added the released label Feb 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: disable create page btn if the page name is missing #857

feat: disable create page btn if the page name is missing #857

takanome-dev commented Feb 9, 2023 •

edited

netlify bot commented Feb 9, 2023 •

edited

netlify bot commented Feb 10, 2023 •

edited

brandonroberts commented Feb 10, 2023 •

edited

takanome-dev commented Feb 10, 2023

Deadreyo left a comment

0-vortex left a comment

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

feat: disable create page btn if the page name is missing #857

feat: disable create page btn if the page name is missing #857

Conversation

takanome-dev commented Feb 9, 2023 • edited

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Feb 9, 2023 • edited

✅ Deploy Preview for design-insights ready!

netlify bot commented Feb 10, 2023 • edited

✅ Deploy Preview for oss-insights ready!

brandonroberts commented Feb 10, 2023 • edited

takanome-dev commented Feb 10, 2023

Deadreyo left a comment

Choose a reason for hiding this comment

0-vortex left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

takanome-dev commented Feb 9, 2023 •

edited

netlify bot commented Feb 9, 2023 •

edited

netlify bot commented Feb 10, 2023 •

edited

brandonroberts commented Feb 10, 2023 •

edited