Fix vite build
#11
Merged
Fix vite build
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I can train successfully in |
|
I'm not sure if it's possible to directly use Rollup to solve compatibility issues after compiling fsrs-browser. ts-fsrs uses Rollup to generate ESM/CommonJS bundles. |
|
I'm not very familiar with ESM vs CommonJS - I've little experience with Node. Since this package uses wasm-bindgen-rayon which probably doesn't work in Node (at least I don't see any evidence that it does), can we ignore the compatibility issues and just go with ESM? |
I think at this stage, we can ignore the compatibility issues and proceed with using ESM only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
This PR updates wasm-bindgen-rayon to "1.2.1", which means we no longer need to put
initThreadPool()andfsrs.computeWeightsin a separate web worker. Indeed, in order to getvite buildto work, this must be done. Vite users must also use@surma/rollup-plugin-off-main-threadwhen building, but must not use it indevmode. The PR demos how to do this.@ishiko732 please feel free to test this, submit feedback, or whatever. I know virtually nothing about bundlers, just giving you the chance to say something since we're in the same boat. I also plan on opening an issue/PR with wasm-bindgen-rayon once I catch my breath.