Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/exp initial difficulty [WIP] #91

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented May 17, 2024

Weighted average by reviews:

Algorithm Log Loss RMSE (bins) Parameters
FSRS-4.5 0.3252±0.1514 0.0533±0.0334 17
FSRS-4.5 + exp init d 0.3250±0.1515 0.0530±0.0333 17

Weighted average by log(reviews):

Algorithm Log Loss RMSE (bins) Parameters
FSRS-4.5 0.3485±0.1701 0.0733±0.0474 17
FSRS-4.5 + exp init d 0.3483±0.1702 0.0729±0.0474 17

improved ~0.6% and ~0.5%.

@user1823
Copy link
Contributor

I am not an expert in statistics, but is this actually an improvement? When there is an uncertainty at the 2nd place of decimal in the RMSE, does it make sense to consider the 3rd and the 4th decimal places?

@Expertium, can you confirm?

@Expertium
Copy link
Contributor

Expertium commented May 22, 2024

We would need to run a statistical significance test. @L-M-Sherlock could you please run my logp_wilcox (from significance_table.py) on the baseline values of RMSE and the new values?
Like this: log_p_value = logp_wilcox(baseline_RMSE, new_RMSE)[0]

@L-M-Sherlock
Copy link
Member Author

image

@Expertium
Copy link
Contributor

Expertium commented May 22, 2024

Yep, that's definitely significant. Well, statistically, but not practically, since the effect is only about 0.5%

@Expertium
Copy link
Contributor

As I said here, this is such a minor improvement that even if it's statistically significant, I don't think it's worth implementing. You would need 20 such small improvements to get to the point where the new version is noticeably better than FSRS-4.5.

@L-M-Sherlock L-M-Sherlock merged commit 7a750a2 into main Jul 10, 2024
@L-M-Sherlock L-M-Sherlock deleted the Feat/exp-initial-difficulty branch July 10, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants