Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-actions[bot] to EasyCLA allowlist #809

Closed
dyladan opened this issue Aug 11, 2021 · 13 comments · Fixed by #1285
Closed

Add github-actions[bot] to EasyCLA allowlist #809

dyladan opened this issue Aug 11, 2021 · 13 comments · Fixed by #1285

Comments

@dyladan
Copy link
Member

dyladan commented Aug 11, 2021

Similar to #306 which was resolved by @lizthegrey making a request to the CNCF: https://jira.linuxfoundation.org/servicedesk/customer/portal/4/SUPPORT-1388

I would make a similar request myself (as a member of the GC) but I'm honestly not sure if I have the authority to do so without official approval of the GC or TC.

Example PR with failing CLA open-telemetry/opentelemetry-js#2409

@lizthegrey
Copy link
Member

@open-telemetry/governance-committee can we get a vote please?

@lizthegrey
Copy link
Member

lizthegrey commented Aug 16, 2021

that's certainly unanimous. submitting ticket. https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/SUPPORT-6356

@dyladan
Copy link
Member Author

dyladan commented Aug 23, 2021

Is there any update on this?

@lizthegrey
Copy link
Member

EasyCLA ticket marked as work in progress

@dyladan
Copy link
Member Author

dyladan commented Aug 24, 2021

Should I be worried the CNCF might deny this request? I hadn't expected it to take more than a week after the ticket was created in their system.

@lizthegrey
Copy link
Member

No, they just have never had a request for github-actions[bot] to be exempted whereas they have had dependabot added before.

@lizthegrey
Copy link
Member

lizthegrey commented Aug 25, 2021

here's the answer as to why this is complex:

Typically when we approve a bot under EasyCLA, we are able to use the bot name and github id as the identifier to approve on a per cla group basis, because the bots approved have a predefined scope of actions. The issue is that if we approve this set of actions for your repo, then that would potentially approve any set of actions created for any repos under the CNCF cla group. We are currently working through how we can do this for you, but if you have any suggestions, please feel free to make them!

@dyladan
Copy link
Member Author

dyladan commented Aug 26, 2021

It might turn out not to matter. The branch protection rules added automatically by CNCF are actually blocking this and other use-cases. Unless we can get that resolved, we will have to figure out some workaround to create releases on a fork or something anyway.

@lizthegrey
Copy link
Member

I can disable the branch protection rule enforcement.

@bogdandrutu
Copy link
Member

@lizthegrey any update on this?

@trask
Copy link
Member

trask commented Jan 18, 2022

The issue is that if we approve this set of actions for your repo, then that would potentially approve any set of actions created for any repos under the CNCF cla group.

To address this concern, is it an option to create our own bot account(s), scoped either to opentelemetry, or even to a specific opentelemetry repository?

@lizthegrey
Copy link
Member

Yes, that would be better, then CNCF could approve that specific bot.

@dyladan
Copy link
Member Author

dyladan commented Jan 19, 2022

So the workaround is to register a user in github, give that user permission, and generate a token to perform actions on behalf of that user. CNCF can then allowlist the user as a bot user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants