signalfxexporter: Update exclude_metrics option to use dpfilters.MetricFilter #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jrcamp |
asuresh4
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
==========================================
+ Coverage 89.15% 90.38% +1.22%
==========================================
Files 393 393
Lines 19329 19409 +80
==========================================
+ Hits 17233 17542 +309
+ Misses 1641 1405 -236
- Partials 455 462 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
sfxexporter-use-dp-filters
branch
from
e3d7f77
to
1e5a978
Compare
|
|
||
| type dataPointFilter struct { | ||
| metricFilter *stringFilter | ||
| dimensionsFilter *dimensionsFilter |
There was a problem hiding this comment.
Are these pointers for performance reasons?
There was a problem hiding this comment.
Not really. I guess I just started out with them. Would you advocate for one vs the other?
asuresh4
force-pushed
the
sfxexporter-use-dp-filters
branch
3 times, most recently
from
9169c99
to
8e6ee68
Compare
asuresh4
changed the title
asuresh4
force-pushed
the
sfxexporter-use-dp-filters
branch
2 times, most recently
from
c059d51
to
9bc9bc4
Compare
…icFilter This is breaking change to exclude_metrics config option. Now, it takes metric filters instead of just metric names.
asuresh4
force-pushed
the
sfxexporter-use-dp-filters
branch
from
9bc9bc4
to
803dbaf
Compare
jrcamp
reviewed
Jan 15, 2021
| dimension_key: dimension_val | ||
| - metric_name: metric5 | ||
| dimensions: | ||
| dimension_key: [dimension_val1, dimension_val2] |
There was a problem hiding this comment.
This supports /regex/ and glob.* form too right? Should probably document/give examples those.
There was a problem hiding this comment.
That's a good point. Added a few examples.
jrcamp
approved these changes
Jan 19, 2021
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Adds a `send_timestamps` option to the prometheus exporter to allow it to send scrape timestamps. By default, when scraping, Prometheus records data assuming that the presented sample is at the instant of the scrape. For data sources that cache the underlying information and do not refresh on scrape, this can lead to metric samples being recorded at the wrong timestamp. For ex, cadvisor caches for many seconds (4-20 in our experience), and so a sample taken "now" may actually be a sample from 20s ago. To handle this situation, the exposition format allows an exporter to advise the Prometheus server of the timestamp of the underlying scrape. OpenTelemetry is aware of the timestamp of the scrape. This change adds an option to have OpenTelemetry send the timestamps of underlying samples out with the Prometheus exporter. Visually, the image shows existing behavior prior to 9.45am and with `send_timestamps: true` set from 9.45am onwards. This is metrics for a job using a single CPU.  **Related issues:** google/cadvisor#2526 orijtech/prometheus-go-metrics-exporter#11 **Testing:** Test cases have been added. In addition, for e2e test, see screenshot from our environment above. **Documentation:** The `prometheusexporter` README has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1950
Description: Update
exclude_metricsconfig option to usedpfilters.MetricFilter. This is breaking change to exclude_metrics config option. Now, it takes slice of metric filters instead of just metric names (slice of strings).Testing: Updated tests.
Documentation: Updated README.
Not included in this PR but subsequent changes I'm looking to make