2/2 Extend receiverhelper scraper functions to simplify the scrape function interface #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
commented
Oct 2, 2020
| rm := rms.At(0) | ||
| ilms := rm.InstrumentationLibraryMetrics() | ||
| ilms.Resize(1) | ||
| ilm := ilms.At(0) |
There was a problem hiding this comment.
For metrics that we "scrape", would we want to fill in Instrumentation Library data btw?
There was a problem hiding this comment.
It's possible, see open-telemetry/opentelemetry-collector-contrib#1099
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
+ Coverage 91.39% 91.40% +0.01%
==========================================
Files 284 284
Lines 16740 16784 +44
==========================================
+ Hits 15299 15341 +42
- Misses 1009 1010 +1
- Partials 432 433 +1
Continue to review full report at Codecov.
|
…rape metrics slice or resource metrics slice instead of having to return a metrics data object)
james-bebbington
force-pushed
the
receiverhelper-scrapers-2
branch
from
b760482
to
785218e
Compare
jrcamp
approved these changes
Oct 9, 2020
bogdandrutu
approved these changes
Oct 9, 2020
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 30, 2020
…#1211) Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details. **Link to tracking Issue:** #1088 Note the scaffolding code makes use of the new `receiverhelper` & `scraperhelper` functions added in the Core PRs referenced below. **Depends on:** #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users of this API to provide a scrape function that returns:
(instead of having to return a fully constructed
pdata.Metricsobject)Depends on: #1886