Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2/3 Add Windows Performance Counters Receiver skeleton implementation #1211

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Oct 6, 2020

Link to tracking Issue: #1088

Description: Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details.

Note the scaffolding code makes use of the new receiverhelper & scraperhelper functions added in the Core PRs referenced below.

Depends on: #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890

@james-bebbington james-bebbington requested a review from a team October 6, 2020 03:07
@james-bebbington james-bebbington changed the title Add Windows Performance Counters Receiver skeleton implementation 2/2 Add Windows Performance Counters Receiver skeleton implementation Oct 6, 2020
@james-bebbington james-bebbington force-pushed the windowsperfcounters-receiver-2 branch 3 times, most recently from e48ca5b to 66d0137 Compare October 6, 2020 03:35
@james-bebbington james-bebbington changed the title 2/2 Add Windows Performance Counters Receiver skeleton implementation 2/3 Add Windows Performance Counters Receiver skeleton implementation Oct 9, 2020
Copy link
Member

@asuresh4 asuresh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint. I believe a rebase to pull newer version of core should help, it's complaining about ScraperSettings not being declared in receiverhelper.

@james-bebbington
Copy link
Member Author

Please fix lint. I believe a rebase to pull newer version of core should help, it's complaining about ScraperSettings not being declared in receiverhelper.

Will come back to this PR once the Scraper library is finalized in core

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 23, 2020
@james-bebbington james-bebbington force-pushed the windowsperfcounters-receiver-2 branch 3 times, most recently from 944df77 to 71ffa05 Compare October 29, 2020 09:06
@james-bebbington
Copy link
Member Author

This is ready for review now

@james-bebbington james-bebbington force-pushed the windowsperfcounters-receiver-2 branch 4 times, most recently from f9b6b1b to d6a31a7 Compare October 29, 2020 10:48
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1211 into master will increase coverage by 17.89%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1211       +/-   ##
===========================================
+ Coverage   70.87%   88.77%   +17.89%     
===========================================
  Files          29      344      +315     
  Lines        1298    16682    +15384     
===========================================
+ Hits          920    14809    +13889     
- Misses        321     1406     +1085     
- Partials       57      467      +410     
Flag Coverage Δ
#integration 70.87% <ø> (ø)
#unit 88.04% <93.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/windowsperfcountersreceiver/factory.go 88.23% <88.23%> (ø)
receiver/windowsperfcountersreceiver/config.go 100.00% <100.00%> (ø)
...iver/windowsperfcountersreceiver/factory_others.go 100.00% <100.00%> (ø)
exporter/kinesisexporter/exporter.go 21.73% <0.00%> (ø)
exporter/stackdriverexporter/factory.go 80.00% <0.00%> (ø)
exporter/datadogexporter/metrics_translator.go 65.51% <0.00%> (ø)
...xporter/signalfxcorrelationexporter/correlation.go 75.92% <0.00%> (ø)
receiver/statsdreceiver/reporter.go 88.23% <0.00%> (ø)
...xporter/alibabacloudlogserviceexporter/uploader.go 100.00% <0.00%> (ø)
...eceiver/k8sclusterreceiver/collection/collector.go 22.66% <0.00%> (ø)
... and 325 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d65d7...fba4359. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 9b9dd09 into open-telemetry:master Oct 30, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants