-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2/3 Add Windows Performance Counters Receiver skeleton implementation #1211
2/3 Add Windows Performance Counters Receiver skeleton implementation #1211
Conversation
e48ca5b
to
66d0137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint. I believe a rebase to pull newer version of core should help, it's complaining about ScraperSettings
not being declared in receiverhelper
.
Will come back to this PR once the Scraper library is finalized in core |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
944df77
to
71ffa05
Compare
This is ready for review now |
f9b6b1b
to
d6a31a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
===========================================
+ Coverage 70.87% 88.77% +17.89%
===========================================
Files 29 344 +315
Lines 1298 16682 +15384
===========================================
+ Hits 920 14809 +13889
- Misses 321 1406 +1085
- Partials 57 467 +410
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
receiver/windowsperfcountersreceiver/windowsperfcounters_scraper.go
Outdated
Show resolved
Hide resolved
d6a31a7
to
fba4359
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Link to tracking Issue: #1088
Description: Adds skeleton for Windows Performance Counters Receiver with very basic initial functionality that can read simple counters that do not include any instance into a Gauge metric - see the added README.md for more details.
Note the scaffolding code makes use of the new
receiverhelper
&scraperhelper
functions added in the Core PRs referenced below.Depends on: #1175, open-telemetry/opentelemetry-collector#1886, open-telemetry/opentelemetry-collector#1890