Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance tracing support for payment service (node.js) #53

Closed
5 of 10 tasks
cartersocha opened this issue May 30, 2022 · 2 comments · Fixed by #157
Closed
5 of 10 tasks

Review and enhance tracing support for payment service (node.js) #53

cartersocha opened this issue May 30, 2022 · 2 comments · Fixed by #157
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)
  • Update the centralized tracing doc

Referencing: #42

Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/paymentservice/README.md

@cartersocha cartersocha added enhancement New feature or request help wanted Extra attention is needed required-for-release labels May 30, 2022
@cartersocha cartersocha reopened this Jun 23, 2022
@julianocosta89
Copy link
Member

I've checked the following 2 points as we already have automatic instrumentation in the payment service:

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.

https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/paymentservice/tracing.js#L7

@cartersocha
Copy link
Contributor Author

Tracing is code complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants