Skip to content

Commit

Permalink
Remove Moq from ResourceDetectors.AWS.Tests (#1483)
Browse files Browse the repository at this point in the history
  • Loading branch information
ngruson committed Dec 11, 2023
1 parent 8e8995f commit 5efd368
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@
#if !NETFRAMEWORK

using System.Security.Cryptography.X509Certificates;
using Moq;
using OpenTelemetry.ResourceDetectors.AWS.Http;
using Xunit;

namespace OpenTelemetry.ResourceDetectors.AWS.Tests.Http;

public class ServerCertificateValidationProviderTests
{
private const string InvalidCertificateName = "invalidcert";
private const string InvalidCertificateName = "invalidCert";

[Fact]
public void TestValidCertificate()
Expand Down Expand Up @@ -54,7 +53,7 @@ public void TestTestCallbackWithNullCertificate()
ServerCertificateValidationProvider.FromCertificateFile(certificateUploader.FilePath);

Assert.NotNull(serverCertificateValidationProvider);
Assert.False(serverCertificateValidationProvider.ValidationCallback(this, null, Mock.Of<X509Chain>(), default));
Assert.False(serverCertificateValidationProvider.ValidationCallback(this, null, new X509Chain(), default));
}

[Fact]
Expand All @@ -67,7 +66,7 @@ public void TestCallbackWithNullChain()
ServerCertificateValidationProvider.FromCertificateFile(certificateUploader.FilePath);

Assert.NotNull(serverCertificateValidationProvider);
Assert.False(serverCertificateValidationProvider.ValidationCallback(this, Mock.Of<X509Certificate2>(), null, default));
Assert.False(serverCertificateValidationProvider.ValidationCallback(this, new X509Certificate2(certificateUploader.FilePath), null, default));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
<Nullabe>enable</Nullabe>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Moq" Version="$(MoqPkgVer)" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="$(RepoRoot)\src\OpenTelemetry.ResourceDetectors.AWS\OpenTelemetry.ResourceDetectors.AWS.csproj" />
</ItemGroup>
Expand Down

0 comments on commit 5efd368

Please sign in to comment.