Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Moq from ResourceDetectors.AWS.Tests #1483

Merged

Conversation

ngruson
Copy link
Contributor

@ngruson ngruson commented Dec 9, 2023

Related to #1467

Remove the Moq library from the ResourceDetectors.AWS.Tests project.

Changes

  • Updated unit tests
  • Removed Moq dependency

@ngruson ngruson requested a review from a team December 9, 2023 10:54
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #1483 (8c89b1d) into main (71655ce) will increase coverage by 7.19%.
Report is 88 commits behind head on main.
The diff coverage is 90.32%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   73.91%   81.10%   +7.19%     
==========================================
  Files         267      124     -143     
  Lines        9615     3451    -6164     
==========================================
- Hits         7107     2799    -4308     
+ Misses       2508      652    -1856     
Flag Coverage Δ
unittests-Solution 81.10% <90.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Telemetry.Exporter.InfluxDB/InfluxDBEventSource.cs 60.00% <ø> (ø)
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 100.00% <100.00%> (ø)
...metry.Exporter.InfluxDB/InfluxDBMetricsExporter.cs 84.61% <ø> (-3.85%) ⬇️
...Telemetry.Exporter.InfluxDB/PointDataExtensions.cs 87.50% <ø> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV1.cs 100.00% <ø> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV2.cs 100.00% <ø> (ø)
...stana/Implementation/InstanaExporterEventSource.cs 0.00% <ø> (ø)
...try.Exporter.Instana/Implementation/InstanaSpan.cs 100.00% <ø> (ø)
...orter.Instana/Implementation/InstanaSpanFactory.cs 100.00% <ø> (ø)
...er.Instana/Implementation/InstanaSpanSerializer.cs 93.79% <ø> (ø)
... and 48 more

... and 208 files with indirect coverage changes

@Kielek Kielek added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Dec 11, 2023
@Kielek Kielek merged commit 5efd368 into open-telemetry:main Dec 11, 2023
@ngruson ngruson deleted the remove-moq-resourcedetectors-aws-tests branch December 12, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants