Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore] Move package from main repository #1707

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 8, 2024

Towards open-telemetry/opentelemetry-dotnet#5526

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 85.27607% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 76.18%. Comparing base (71655ce) to head (91063ef).
Report is 227 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
+ Coverage   73.91%   76.18%   +2.27%     
==========================================
  Files         267      296      +29     
  Lines        9615    11540    +1925     
==========================================
+ Hits         7107     8792    +1685     
- Misses       2508     2748     +240     
Flag Coverage Δ
unittests-Exporter.Geneva 63.72% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.69% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <85.27%> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 81.96% <ø> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...umentation.AspNetCore/AspNetCoreInstrumentation.cs 100.00% <100.00%> (ø)
...reInstrumentationMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...eInstrumentationTracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ry.Instrumentation.AspNetCore/AspNetCoreMetrics.cs 100.00% <100.00%> (ø)
...spNetCore/AspNetCoreTraceInstrumentationOptions.cs 95.23% <95.23%> (ø)
...ation.AspNetCore/Implementation/TelemetryHelper.cs 88.88% <88.88%> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <89.74%> (ø)
...ementation/AspNetCoreInstrumentationEventSource.cs 66.66% <66.66%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 77.02% <77.02%> (ø)

... and 252 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 8, 2024 07:23
@Kielek Kielek requested a review from a team as a code owner May 8, 2024 07:23
@vishweshbankwar vishweshbankwar merged commit 4fe7355 into open-telemetry:main May 8, 2024
146 of 147 checks passed
@Kielek Kielek deleted the migrate-aspnetcoreinstrumentation branch May 9, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants