[Instrumentation.AspNetCore] Move to contrib repository #5599
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5599 +/- ##
==========================================
+ Coverage 83.38% 85.90% +2.52%
==========================================
Files 297 254 -43
Lines 12531 10963 -1568
==========================================
- Hits 10449 9418 -1031
+ Misses 2082 1545 -537
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kielek
changed the title
| @@ -31,7 +31,6 @@ jobs: | |||
| api-code: ['*/OpenTelemetry.Api*/**', '!**/*.md'] | |||
| api-packages: ['src/OpenTelemetry.Api*/**', '!**/*.md'] | |||
| instrumentation: ['*/OpenTelemetry.Instrumentation*/**', 'test/TestApp.AspNetCore/**', '!**/*.md'] | |||
| instrumentation-packages: ['src/OpenTelemetry.Instrumentation*/**', '!**/*.md'] | |||
There was a problem hiding this comment.
Is anything using the line above this one?
There was a problem hiding this comment.
Yes, it is strange way to execute https://github.com/open-telemetry/opentelemetry-dotnet/tree/3db49191410ec0b0cbe6f754510a4dc7c2a86dd3/test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests
Probably can be renamed to something more meaningful, but I would prefer to keep as is in this PR.
There was a problem hiding this comment.
Fine to leave it alone. I don't think the design for W3cTraceContext.Tests is really all that great. It is verifying/testing bits/logic inside the OpenTelemetry.Api project. Ideally it would be a test inside OpenTelemetry.Api.Tests and not use any instrumentation projects to do its work. Just haven't had the time/desire to do something about it 🤣
Towards: #5526
Related to: open-telemetry/opentelemetry-dotnet-contrib#1707
Changes
[Instrumentation.AspNetCore] Move to contrib repository
Known leftowers:
Merge requirement checklist
[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)