-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis: Adding the ability to disable adding Events to Activities #416
Conversation
Another option might be to convert these Events into Tags instead, in case users do not want a separate event for these but would still like the info to be part of the span. |
...elemetry.Instrumentation.StackExchangeRedis/StackExchangeRedisCallsInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 163 163
Lines 4907 4909 +2
=====================================
- Misses 4907 4909 +2
|
Fixing markdown linting errors.
2f00d5f
to
e3ffced
Compare
This is exactly what I was about to create a PR for. Thank you @stebet! In my case, I'm using Elasticsearch APM and it is converting these activity events into log messages and flooding my app logs with literally millions and millions of useless log messages: |
It would be super appreciated if we could get this PR merged and a new nuget package pushed out because this behavior is killing my ES APM logs. |
we can merge once CI is green. @stebet could you fix the markdownlint issues? |
Awesome! Can we get a new release pushed out? Also, while we are at it, can we do a new release for the Elasticsearch package as well? |
Changes
Adds an option for OpenTelemetry.Instrumentation.StackExchangeRedis to disable adding the Redis command lifetime ActivityEvents to Activities. Added this because for example in Honeycomb, Span Events are billed and measured just like individual spans, so Activity Events can quickly gobble up telemetry budgets.
CHANGELOG.md
updated for non-trivial changes