Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventCounter API feedback #1502

Closed
cijothomas opened this issue Nov 10, 2020 · 4 comments
Closed

EventCounter API feedback #1502

cijothomas opened this issue Nov 10, 2020 · 4 comments
Labels
metrics Metrics signal related

Comments

@cijothomas
Copy link
Member

As mentioned in #1501. OpenTelemetry .NET Sig and .NET Runtime team is looking for feedback on EventCounters API. Please comment on this issue if you have any feedback to share.

Are you using EventCounters in any way in your applications?
If yes, are you simply consuming EventCounters?
If yes, are you consuming EventCounters published by components in .NET Ecosystem (eg: .NET Runtime, Asp.Net Core etc.) or by libraries other than the ones shipped by Microsoft/.NET.
Are you publishing Metrics using EventCounters?

@cijothomas cijothomas added the question Further information is requested label Nov 10, 2020
@cijothomas cijothomas removed the question Further information is requested label Nov 10, 2020
@Im5tu
Copy link
Contributor

Im5tu commented Dec 9, 2020

In short, yes to all. We publish out custom metrics, subscribing to those plus a lot of .NET metrics. Currently using custom sinks to publish to either DataDog or CloudWatch depending on use case. We have tagging etc built in using the metadata portion of EventCounters. Want to continue using them going forward as built in .NET tooling support is getting better (eg: viewing counters from Visual Studio, dotnet counters cli etc).

Approach is described in detail on my blog (more links at the bottom including how we pull the correct http stats)

@vcx
Copy link

vcx commented Dec 11, 2020

+1 for the need or EventSource and others. EventSource is kind of new in .NET Core, but the underlying tech (ETW) a very reliable, known, and trusted for troubleshooting nasty performance problems since .NET 2.0. There's lots of tooling available to parse and investigate results, and I can't count how many times this little known part of .NET saved me in my past consulting jobs.

@cijothomas cijothomas added the metrics Metrics signal related label Apr 15, 2021
@cijothomas
Copy link
Member Author

Closing this issue. open-telemetry/opentelemetry-dotnet-contrib#215 is to track supporting EventCounter -> New metric API.

@cijothomas
Copy link
Member Author

@Im5tu if your time permits, we could use reviews on open-telemetry/opentelemetry-dotnet-contrib#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related
Projects
None yet
Development

No branches or pull requests

3 participants