Skip to content

Commit

Permalink
otelslog: Refine TestNewHandlerConfiguration (#5484)
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared committed May 8, 2024
1 parent aaa4a03 commit 8c9b579
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions bridges/otelslog/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,13 @@ func TestSLogHandler(t *testing.T) {
func TestNewHandlerConfiguration(t *testing.T) {
t.Run("Default", func(t *testing.T) {
r := new(recorder)
prev := global.GetLoggerProvider()
defer global.SetLoggerProvider(prev)
global.SetLoggerProvider(r)

var h *Handler
assert.NotPanics(t, func() { h = NewHandler() })
assert.NotNil(t, h.logger)
require.NotPanics(t, func() { h = NewHandler() })
require.NotNil(t, h.logger)
require.IsType(t, &recorder{}, h.logger)

l := h.logger.(*recorder)
Expand All @@ -440,13 +442,13 @@ func TestNewHandlerConfiguration(t *testing.T) {
r := new(recorder)
scope := instrumentation.Scope{Name: "name", Version: "ver", SchemaURL: "url"}
var h *Handler
assert.NotPanics(t, func() {
require.NotPanics(t, func() {
h = NewHandler(
WithLoggerProvider(r),
WithInstrumentationScope(scope),
)
})
assert.NotNil(t, h.logger)
require.NotNil(t, h.logger)
require.IsType(t, &recorder{}, h.logger)

l := h.logger.(*recorder)
Expand Down

0 comments on commit 8c9b579

Please sign in to comment.