Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelslog: Refine TestNewHandlerConfiguration #5484

Merged
merged 2 commits into from
May 8, 2024
Merged

otelslog: Refine TestNewHandlerConfiguration #5484

merged 2 commits into from
May 8, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented May 7, 2024

  1. Revert to previously used global provider
  2. Use require instead of assert when it does not make sense to continue the test

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 7, 2024
@pellared pellared requested a review from a team as a code owner May 7, 2024 13:19
@pellared
Copy link
Member Author

pellared commented May 7, 2024

@MrAlias PTAL

@pellared pellared merged commit 8c9b579 into open-telemetry:main May 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pellared @dashpole @MrAlias @XSAM