Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macaron instrumentation is missing v0.11 tag #352

Closed
vmihailenco opened this issue Sep 18, 2020 · 6 comments · Fixed by #356
Closed

macaron instrumentation is missing v0.11 tag #352

vmihailenco opened this issue Sep 18, 2020 · 6 comments · Fixed by #356
Assignees
@amanbrar1999
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working good first issue Good for newcomers
Projects
OpenTelemetry Go RC

Comments

@vmihailenco
Copy link
Contributor 

go get go.opentelemetry.io/contrib/instrumentation/macaron
go: downloading go.opentelemetry.io/contrib/instrumentation/macaron v0.6.1
pkg/mod/go.opentelemetry.io/contrib@v0.6.1/internal/trace/http.go:26:2: module go.opentelemetry.io/otel@latest found (v0.11.0), but does not contain package go.opentelemetry.io/otel/api/kv
@Aneurysm9
Copy link
Member

It looks like that instrumentation was moved to instrumentation/gopkg.in/macron.v1 in #92 but the module declaration in go.mod was not updated. Using the old import path is giving a very old version of the module.

@Aneurysm9 Aneurysm9 added area: instrumentation Related to an instrumentation package bug Something isn't working good first issue Good for newcomers priority:p1 labels Sep 18, 2020
@amanbrar1999
Copy link
Contributor

Is this issue free to pick up? @Aneurysm9 - cc @alolita

@amanbrar1999 amanbrar1999 mentioned this issue Sep 18, 2020
Merged
This was referenced Sep 21, 2020
Merged
Closed
@MrAlias MrAlias linked a pull request Sep 22, 2020 that will close this issue
updated macaron go module declaration #356
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Sep 22, 2020

Closed by #356

@MrAlias MrAlias closed this as completed Sep 22, 2020
@vmihailenco
Copy link
Contributor Author

pkg.go.dev still says

“go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1” is not a valid package or module. Were you looking for “go.opentelemetry.io/contrib/instrumentation/macaron”?

Did you tag fixed version?

@amanbrar1999
Copy link
Contributor

Does this just require a git tag to be pushed called something like instrumentation/gopkg.in/macaron.v1/v0.9.1?
I don't have permission to push tags

@Aneurysm9
Copy link
Member

Yes, this will require that we make a new release. I intend to do this tonight or tomorrow, depending on how many outstanding PRs we can resolve today.

@MrAlias MrAlias added this to Done in OpenTelemetry Go RC Oct 13, 2020
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@evantorrie @jmacd
Add Min() interface - rename MaxSumCount to MinMaxSumCount (#352)
fef504d 
* Add Min() interface - rename MaxSumCount to MinMaxSumCount

Fixes open-telemetry/opentelemetry-go#319

* update stdout exporter to collect and output the minimum value
* update min and max atomically in Aggregator Update
* changed all references to maxsumcount to minmaxsumcount

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanbrar1999 amanbrar1999

Labels
area: instrumentation Related to an instrumentation package bug Something isn't working good first issue Good for newcomers
Projects
No open projects
OpenTelemetry Go RC
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated macaron go module declaration open-o11y/opentelemetry-go-contrib
4 participants
@vmihailenco @Aneurysm9 @MrAlias @amanbrar1999