Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated macaron go module declaration #356

Merged

Conversation

amanbrar1999
Copy link
Contributor

Simple bug fix, the module declaration was not previously updated to match the updated file hierarchy. Fixes issue #352

@MrAlias
Copy link
Contributor

MrAlias commented Sep 21, 2020

It looks like this needs to be updated in a few places:

% grep -Rn 'go.opentelemetry.io/contrib/instrumentation/macaron'
instrumentation/gopkg.in/macaron.v1/doc.go:20:package macaron // import "go.opentelemetry.io/contrib/instrumentation/macaron"
instrumentation/gopkg.in/macaron.v1/macaron_test.go:46:		assert.Equal(t, "go.opentelemetry.io/contrib/instrumentation/macaron", mockTracer.Name)
instrumentation/gopkg.in/macaron.v1/go.mod:1:module go.opentelemetry.io/contrib/instrumentation/macaron
instrumentation/gopkg.in/macaron.v1/example/server.go:23:	macarontrace "go.opentelemetry.io/contrib/instrumentation/macaron"
instrumentation/gopkg.in/macaron.v1/config.go:33:// "go.opentelemetry.io/contrib/instrumentation/macaron" from the global
instrumentation/gopkg.in/macaron.v1/macaron.go:30:	tracerName = "go.opentelemetry.io/contrib/instrumentation/macaron"

@amanbrar1999
Copy link
Contributor Author

@MrAlias updates have been made in all requested places

@MrAlias
Copy link
Contributor

MrAlias commented Sep 22, 2020

Going to merge with one approval given the "typo fix" nature.

@MrAlias MrAlias merged commit 96b0b00 into open-telemetry:master Sep 22, 2020
@MrAlias MrAlias linked an issue Sep 22, 2020 that may be closed by this pull request
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macaron instrumentation is missing v0.11 tag
2 participants