Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project docs and layout #92

Merged
merged 7 commits into from
Jun 22, 2020
Merged

Update project docs and layout #92

merged 7 commits into from
Jun 22, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 18, 2020

  • Update the README to more than just the bare-bones.
  • Add README to instrumentation directory to provide instructions and context for authors and users.
  • Move the Macaron package to match layout guidelines.

Resolves #28

@MrAlias
Update README and add README for instrumentation
147d013 
Resolves #28
@MrAlias
Fix macaron instrumentation package name
076484c
@MrAlias
Update instrumentation README
4e4f2e9 
Keep Go package docs in Go form.
@MrAlias
Update README
34fac6c 
Add Contents of the repo section and link to CONTRIBUTING.md
@MrAlias MrAlias added the documentation Improvements or additions to documentation label Jun 18, 2020
@MrAlias MrAlias self-assigned this Jun 18, 2020
evantorrie
evantorrie suggested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the gitter 404 link is resolved, this will change to Approved for me.

README.md Outdated Show resolved Hide resolved
@MrAlias
Update README.md
0912cce 
Fix gitter link.
@MrAlias MrAlias merged commit 325b321 into open-telemetry:master Jun 22, 2020
@MrAlias MrAlias deleted the #28 branch June 22, 2020 23:10
@Aneurysm9 Aneurysm9 mentioned this pull request Sep 18, 2020
Closed
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@iredelmeier @rghetia
Export NoopSpan and NoopTracer (#92)
56e1a9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantorrie evantorrie evantorrie approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees

@MrAlias MrAlias

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide on the directory structure of the plugins directory
2 participants
@MrAlias @evantorrie