Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded rename views for otelgocql #2960

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 1, 2022

Revert changes added in #2760

Supersedes #2795

@MrAlias MrAlias added this to the v0.36.5 milestone Nov 1, 2022
@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #2960 (19c52f1) into main (4fe9de8) will increase coverage by 2.9%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2960     +/-   ##
=======================================
+ Coverage   69.6%   72.5%   +2.9%     
=======================================
  Files        147     149      +2     
  Lines       6785    6831     +46     
=======================================
+ Hits        4725    4958    +233     
+ Misses      1944    1743    -201     
- Partials     116     130     +14     
Impacted Files Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 83.0% <0.0%> (-1.0%) ⬇️
...n/github.com/gocql/gocql/otelgocql/test/version.go 0.0% <0.0%> (ø)
.../github.com/gocql/gocql/otelgocql/internal/cass.go 95.1% <0.0%> (ø)
...ntation/github.com/gocql/gocql/otelgocql/config.go 57.1% <0.0%> (+57.1%) ⬆️
...ion/github.com/gocql/gocql/otelgocql/instrument.go 62.5% <0.0%> (+62.5%) ⬆️
...ation/github.com/gocql/gocql/otelgocql/observer.go 75.1% <0.0%> (+75.1%) ⬆️
...entation/github.com/gocql/gocql/otelgocql/gocql.go 100.0% <0.0%> (+100.0%) ⬆️
...tation/github.com/gocql/gocql/otelgocql/version.go 100.0% <0.0%> (+100.0%) ⬆️

@MrAlias MrAlias merged commit 5fd652a into open-telemetry:main Nov 3, 2022
@MrAlias MrAlias deleted the rm-gocql-example-views branch November 3, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation: otelgocql Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants