Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new runtime metrics #5780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jun 18, 2024

Part of #5655

Changes:

Notes:

It doesn't implement go.schedule.duration, as the histogram will need some additional work to figure out.

Based on prometheus/client_golang#955 (comment), using go's runtime metrics should is more efficient than reading memstats.

@dashpole dashpole requested review from MadVikingGod and a team as code owners June 18, 2024 20:46
@dashpole dashpole marked this pull request as draft June 18, 2024 20:46
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 82.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 64.7%. Comparing base (c7fb822) to head (79b1a80).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5780     +/-   ##
=======================================
+ Coverage   64.4%   64.7%   +0.3%     
=======================================
  Files        200     201      +1     
  Lines      12540   12643    +103     
=======================================
+ Hits        8084    8190    +106     
+ Misses      4220    4203     -17     
- Partials     236     250     +14     
Files Coverage Δ
instrumentation/runtime/options.go 100.0% <100.0%> (ø)
instrumentation/runtime/runtime.go 76.7% <79.6%> (+76.7%) ⬆️

... and 2 files with indirect coverage changes

@dashpole dashpole marked this pull request as ready for review June 19, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant