Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime instrumentation to new semantic conventions #5655

Open
MrAlias opened this issue May 23, 2024 · 3 comments
Open

Update runtime instrumentation to new semantic conventions #5655

MrAlias opened this issue May 23, 2024 · 3 comments
Assignees
@dashpole
Labels
area: instrumentation Related to an instrumentation package instrumentation: runtime
Milestone
v1.28.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented May 23, 2024

open-telemetry/semantic-conventions#981
@MrAlias MrAlias added area: instrumentation Related to an instrumentation package instrumentation: runtime labels May 23, 2024
@dashpole
Copy link
Contributor

Do we want a migration plan? Or do we want to just want to switch to the new conventions?

@MrAlias
Copy link
Contributor Author

MrAlias commented May 23, 2024

+1 to just switching.

@MrAlias
Copy link
Contributor Author

MrAlias commented May 23, 2024 •
edited

Migration plan:

  • Add the new semantic conventions, these will be used by default
  • Add option to turn on old metrics (in addition to the new which are default)

The old metrics will be supported for 2 releases. We do not plan to make any changes to the old metrics. If there is any CVEs they will be removed prior to the 2 release timeline.

@MrAlias MrAlias added this to the v1.28.0 milestone May 30, 2024
@dashpole dashpole mentioned this issue Jun 9, 2024
Merged
dashpole added a commit that referenced this issue Jun 13, 2024
@dashpole
Prepare for migration to new runtime metrics (#5747)
ae2a4f0 
Part of #5655

This is a refactoring to prepare for the implementation of the new
runtime metrics. It:

* Adds support for `OTEL_GO_X_DEPRECATED_RUNTIME_METRICS`, which can be
set to `true` or `false` to enable/disable the existing runtime metrics.
It initially defaults to `true` while the new metrics are under
development.
* Moves the existing runtime metrics implementation to its own internal
package, deprecatedruntime, to clearly separate it from the new metrics
being added, and to make the eventual removal easier.

This does not change any of the metrics generated, or the public API
surface of the runtime metrics package.
@dashpole dashpole mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
area: instrumentation Related to an instrumentation package instrumentation: runtime
Projects
None yet
Milestone
v1.28.0
Development

No branches or pull requests
2 participants
@dashpole @MrAlias