Use SingleHeader format for unspecified B3 inject encoding #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunturaf
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=====================================
Coverage 78.0% 78.1%
=====================================
Files 57 57
Lines 2664 2664
=====================================
+ Hits 2080 2082 +2
+ Misses 452 451 -1
+ Partials 132 131 -1
|
MrAlias
requested changes
Mar 16, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 17, 2021
Aneurysm9
approved these changes
Mar 18, 2021
This was referenced Mar 18, 2021
MrAlias
added a commit
that referenced
this pull request
Mar 22, 2021
Missing documentation change from #614.
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Update OTLP SpanData transform The ParentSpanId needs to be empty for root spans according to the OTLP [docs](https://github.com/open-telemetry/opentelemetry-proto/blob/6c2a86ed2f74ca46f979f22c77f0aad449fb9629/gen/go/trace/v1/trace.pb.go#L284-L286). This updates the SpanData transform function to not add the ParentSpanID if it is not a valid span ID (which includes if it is the nil span ID used for an unset ID). Additionally, this adds a test to prevent regression. * Simplify test to just check parent span ID transform Co-authored-by: Rahul Patel <rahulpa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR changes default behavior when B3 inject encoding is unspecified from multi-header to single-header, per #613.
Short description of the changes