Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: Add Unit-Test for Probability Sampler #163

Closed
rghetia opened this issue Oct 3, 2019 · 3 comments · Fixed by #247
Closed

SDK: Add Unit-Test for Probability Sampler #163

rghetia opened this issue Oct 3, 2019 · 3 comments · Fixed by #247
Labels
area:trace Part of OpenTelemetry tracing good first issue Good for newcomers pkg:SDK Related to an SDK package pkg:testing Related to testing or a testing package
Milestone
Alpha v0.2

Comments

@rghetia
Copy link
Contributor

rghetia commented Oct 3, 2019

There is a TODO for adding test for Probability Sampler.
@rghetia rghetia added good first issue Good for newcomers pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing labels Oct 3, 2019
@rghetia rghetia added this to the Alpha v0.2 milestone Oct 3, 2019
@rghetia rghetia added the pkg:testing Related to testing or a testing package label Oct 3, 2019
@iredelmeier
Copy link
Member

@freeformz, it sounds like you want to work on this?

@ghost
Copy link

ghost commented Oct 28, 2019

What should this test, or tests, cover?

@rghetia
Copy link
Contributor Author

rghetia commented Oct 28, 2019

What should this test, or tests, cover?

with AlwaysSample all spans are sampled,
with NeverSample zero spans are sampled,
with probability approximate number of spans are sampled.
Something similar to what is done in OC

ghost pushed a commit to heroku/opentelemetry-go that referenced this issue Oct 29, 2019
sdk/trace: Test the Sampling Probability
9a52d49 
Closes open-telemetry#163
@ghost ghost mentioned this issue Oct 29, 2019
Merged
ghost pushed a commit to heroku/opentelemetry-go that referenced this issue Oct 29, 2019
sdk/trace: Test the Sampling Probability
1423286 
Closes open-telemetry#163
ghost pushed a commit to heroku/opentelemetry-go that referenced this issue Oct 29, 2019
sdk/trace: Test the Sampling Probability
6a8e15b 
Closes open-telemetry#163
ghost pushed a commit to heroku/opentelemetry-go that referenced this issue Oct 29, 2019
sdk/trace: Test the Sampling Probability
057ece4 
Closes open-telemetry#163
rghetia pushed a commit that referenced this issue Oct 29, 2019
@rghetia
sdk/trace: Test the Sampling Probability (#247)
f420f74 
* sdk/trace: Test the Sampling Probability

Closes #163

* Add tests for when the parent is sampled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:trace Part of OpenTelemetry tracing good first issue Good for newcomers pkg:SDK Related to an SDK package pkg:testing Related to testing or a testing package
Projects
None yet
Milestone
Alpha v0.2
Development

Successfully merging a pull request may close this issue.

sdk/trace: Test the Sampling Probability heroku/opentelemetry-go
2 participants
@iredelmeier @rghetia