-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning log on dropped spans in batch span processor #3289
Closed
prodion23
wants to merge
13
commits into
open-telemetry:main
from
prodion23:bsp-logging-on-span-drop
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c97924f
Add warn logging when bsp drops spans
prodion23 e9ccf8c
Merge branch 'main' into bsp-logging-on-span-drop
prodion23 c3d105a
move change to unreleased
prodion23 a754299
Update changelog, fix lint, remove warn log switch to info
prodion23 8630289
Update test
prodion23 5903e9c
Pr feedback, update test with logger reset for race condition
prodion23 ff35927
Merge branch 'main' into bsp-logging-on-span-drop
prodion23 5fba406
pr feedback, lint
prodion23 f344e95
go mod logr
prodion23 bcbd545
Merge remote-tracking branch 'upstream/main' into bsp-logging-on-span…
MadVikingGod e906ef8
Updated test to make it more robust.
MadVikingGod 948dd86
Fixes for lint
MadVikingGod 9af553a
Made the testing logger thread safe.
MadVikingGod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not call
global.Warn
?