Refactor package internal/attribute to not use generics.
#3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Petrie
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 171 171
Lines 12661 12709 +48
=====================================
+ Hits 10087 10126 +39
- Misses 2361 2367 +6
- Partials 213 216 +3
|
dmathieu
reviewed
Feb 14, 2023
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
dmathieu
approved these changes
Feb 14, 2023
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
MrAlias
reviewed
Feb 14, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
MrAlias
approved these changes
Feb 14, 2023
hanyuancheung
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Liu lpfvip2008@gmail.com
resolve #3723