Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor package internal/attribute to not use generics. #3725

Merged
merged 15 commits into from
Feb 15, 2023
Merged

Refactor package internal/attribute to not use generics. #3725

merged 15 commits into from
Feb 15, 2023

Commits on Feb 14, 2023

  1. remove generics 

    Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
    @Petrie
    Petrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5df6686 View commit details
    Browse the repository at this point in the history

  2. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4ea157e View commit details
    Browse the repository at this point in the history

  3. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c2c68ca View commit details
    Browse the repository at this point in the history

  4. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5fadf5f View commit details
    Browse the repository at this point in the history

  5. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b7b43ce View commit details
    Browse the repository at this point in the history

  6. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    eca8ba9 View commit details
    Browse the repository at this point in the history

  7. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    29d31d7 View commit details
    Browse the repository at this point in the history

  8. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b9964c9 View commit details
    Browse the repository at this point in the history

  9. Update internal/attribute/attribute.go 

    Co-authored-by: Damien Mathieu <42@dmathieu.com>
    @Petrie @dmathieu
    Petrie and dmathieu committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2169702 View commit details
    Browse the repository at this point in the history

  10. refactor unit test 

    Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
    @Petrie
    Petrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    235634c View commit details
    Browse the repository at this point in the history

  11. add changelog 

    Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
    @Petrie
    Petrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    240c46f View commit details
    Browse the repository at this point in the history

  12. update changelog 

    Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
    @Petrie
    Petrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e3b185e View commit details
    Browse the repository at this point in the history

  13. Update internal/attribute/attribute.go 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @Petrie @MrAlias
    Petrie and MrAlias committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    555f684 View commit details
    Browse the repository at this point in the history

  14. replace interface{} with any 

    Signed-off-by: Peter Liu <lpfvip2008@gmail.com>
    @Petrie
    Petrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2aa020c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge branch 'main' into attribute-value

    @MrAlias
    MrAlias committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d219eaf View commit details
    Browse the repository at this point in the history