Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Pin otel-specification hyperlinks #4033

Merged
merged 6 commits into from
May 9, 2023

Conversation

pellared
Copy link
Member

Why

Hyperlinks pointing to "main" make the builds flaky. Moreover, it may be hard for the reader if the hyperlink does not work at the time of reading.

What

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #4033 (d06e246) into main (c338d8e) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4033   +/-   ##
=====================================
  Coverage   82.7%   82.7%           
=====================================
  Files        179     179           
  Lines      13498   13498           
=====================================
  Hits       11176   11176           
  Misses      2101    2101           
  Partials     221     221           
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/internal/header.go 100.0% <ø> (ø)
exporters/otlp/otlptrace/internal/header.go 100.0% <ø> (ø)
exporters/prometheus/exporter.go 83.9% <ø> (ø)
exporters/zipkin/model.go 94.7% <ø> (ø)
sdk/resource/resource.go 76.5% <ø> (ø)
sdk/metric/pipeline.go 89.6% <100.0%> (ø)

@MrAlias MrAlias merged commit 4d473d1 into open-telemetry:main May 9, 2023
@pellared pellared deleted the fix-sdk-env-vars-link branch May 9, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants