adds tests for core/span_context.go #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djosephsen
requested review from
bogdandrutu,
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
Closed
rghetia
reviewed
Jul 19, 2019
api/core/span_context_test.go
Outdated
| Low: uint64(42), | ||
| }, | ||
| }, | ||
| want: `000..000`, |
api/core/span_context_test.go
Outdated
| } { | ||
| t.Run(testcase.name, func(t *testing.T) { | ||
| //proto: func (sc SpanContext) TraceIDString() string {} | ||
| have := testcase.sc.SpanIDString() |
There was a problem hiding this comment.
this should testcase.sc.TraceIDString()
|
@djosephsen please sign CLA. |
|
I signed the cla back in June..
|
|
I signed it |
|
(trying the faq fix)
|
are you using same email? |
|
sigh no. Should I close this, fix my config and try again with a new PR? |
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.