-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds tests for core/span_context.go #61
adds tests for core/span_context.go #61
Conversation
api/core/span_context_test.go
Outdated
Low: uint64(42), | ||
}, | ||
}, | ||
want: `000..000`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be non-zero.
api/core/span_context_test.go
Outdated
} { | ||
t.Run(testcase.name, func(t *testing.T) { | ||
//proto: func (sc SpanContext) TraceIDString() string {} | ||
have := testcase.sc.SpanIDString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should testcase.sc.TraceIDString()
@djosephsen please sign CLA. |
I signed it |
(trying the faq fix)
|
are you using same email? |
sigh no. Should I close this, fix my config and try again with a new PR? |
No description provided.