Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-javaagent-1.2.0.jar includes all dependencies and all exporters #3082

Closed
tobias- opened this issue May 25, 2021 · 0 comments · Fixed by #3286
Closed

opentelemetry-javaagent-1.2.0.jar includes all dependencies and all exporters #3082

tobias- opened this issue May 25, 2021 · 0 comments · Fixed by #3286
Labels
bug Something isn't working
Milestone

Comments

@tobias-
Copy link

tobias- commented May 25, 2021

Describe the bug
opentelemetry-javaagent-1.2.0.jar includes all dependencies. While that is expected for opentelemetry-javaagent-1.2.0-all.jar, the one without -all should not include the exporters.

Steps to reproduce
Go to e.g. Maven Central and download the non-all version.

A)

unzip -v opentelemetry-javaagent-1.2.0.jar  | grep -F " inst/"

B)

unzip -v opentelemetry-javaagent-1.2.0.jar  | grep -F "inst/io/opentelemetry/exporter/"

What did you expect to see?
A) I believe this should return an empty response
B) I'm sure this should return an empty response.

What did you see instead?
A) approx 15'000 files in
B) 142 files

What version are you using?
v1.2.0

Environment
Not relevant.

Additional context

Slack thread

In the above slack thread @anuraaga wrote:

The agent doesn’t use code from the app so both versions are supposed to have dependencies, while the -all is supposed to in 
addition include all exporters. If even the non -all had no dependencies included it wouldn’t work as a javaagent.
@tobias- tobias- added the bug Something isn't working label May 25, 2021
@trask trask added this to the 1.3.0 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants