Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PKCS1 encoded private keys #5245

Closed
chicobento opened this issue Feb 23, 2023 · 2 comments
Closed

Support PKCS1 encoded private keys #5245

chicobento opened this issue Feb 23, 2023 · 2 comments
Labels
Feature Request Suggest an idea for this project help wanted

Comments

@chicobento
Copy link
Contributor

chicobento commented Feb 23, 2023

Describe the bug
The setClientTls method supported by client builders such as OtlpHttpSpanExporterBuilder takes only the raw pem files as byte array and takes care of the conversion. However, the conversion code on does not support PKCS1 format, as supported by default for many certificate providers such as cert-manager.

Although this is fair and can be a design choice given that PKCS1 is not supported out-of-the-box by the JDK (bouncy castle supports it), alternative means to reach support for PKCS1 type of keys must be provided, such as supporting more generic arguments such as SSLContext as requested on #5211. As of now, the only way to support PKCS1 is to re-write most of the SDK client code.

@chicobento chicobento added the Bug Something isn't working label Feb 23, 2023
@jkwatson jkwatson added help wanted Feature Request Suggest an idea for this project and removed Bug Something isn't working labels Feb 25, 2023
@jack-berg
Copy link
Member

Closing since we support low level configuration of the SSL context in #5280. It seems unlikely that we would add direct support for formats not supported out of the box by the JDK since we try to avoid dependencies.

@chicobento
Copy link
Contributor Author

Makes sense, thanks a lot team for assisting on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project help wanted
Projects
None yet
Development

No branches or pull requests

3 participants